Skip to content

fix(rocprofiler-sdk): allow PYTHON_EXECUTABLES to be passed in from TheRock #10198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amd-hsivasun merged 5 commits into from
Sep 30, 2026
Merged

fix(rocprofiler-sdk): allow PYTHON_EXECUTABLES to be passed in from TheRock #10198

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
242d371
allow PYTHON_EXECUTABLES to bepassed in
yhuiYH Aug 15, 2026
bc91b38
normalize requeste _VERSION to just parse & compare Python Major.Mino…
yhuiYH Aug 17, 2026
1e1e721
get_default_python_version checks if PYTHON_EXECUTABLES is provided, …
yhuiYH Sep 17, 2026
3bdd9fa
Merge branch 'develop' into users/yhui/use-passed-in-python-versions-…
jayhawk-commits Sep 21, 2026
bc95350
make and use common rocprofiler_get_python_executable_version function
yhuiYH Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions projects/rocprofiler-sdk/source/lib/python/utilities.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,52 @@ if(ROCPROFILER_MEMCHECK)
set(ROCPROFILER_BUILD_Find_Python3_COMPONENTS "Interpreter" "Development")
endif()

# sets _VAR to "<MAJOR>.<MINOR>" of the python executable _EXE, or empty on failure
function(rocprofiler_get_python_executable_version _EXE _VAR)
execute_process(
COMMAND "${_EXE}" -c
"import sys; print(f'{sys.version_info.major}.{sys.version_info.minor}')"
OUTPUT_VARIABLE _EXE_VER
OUTPUT_STRIP_TRAILING_WHITESPACE
RESULT_VARIABLE _EXE_RESULT
ERROR_QUIET)

if(NOT _EXE_RESULT EQUAL 0)
set(_EXE_VER "")
endif()

set(${_VAR}
"${_EXE_VER}"
PARENT_SCOPE)
endfunction()

macro(rocprofiler_find_python3 _VERSION)
rocprofiler_reset_python3_cache()

# If an explicit executable list was provided (e.g. from TheRock via
# -DROCPROFILER_PYTHON_EXECUTABLES), pre-seed Python3_EXECUTABLE for this version
# before calling find_package. This is necessary for Python versions that CMake's
# FindPython3 does not auto-discover (e.g. Python 3.14+ on manylinux where an older
# CMake has no knowledge of the new install path).
if(DEFINED ROCPROFILER_PYTHON_EXECUTABLES)
string(REGEX MATCH "^[0-9]+\\.[0-9]+" _rocprofiler_requested_major_minor
"${_VERSION}")
foreach(_rocprofiler_candidate_exe IN LISTS ROCPROFILER_PYTHON_EXECUTABLES)
rocprofiler_get_python_executable_version("${_rocprofiler_candidate_exe}"
_rocprofiler_candidate_ver)
if(_rocprofiler_candidate_ver AND "${_rocprofiler_candidate_ver}" STREQUAL
"${_rocprofiler_requested_major_minor}")
set(Python3_EXECUTABLE
"${_rocprofiler_candidate_exe}"
CACHE FILEPATH "" FORCE)
break()
endif()
endforeach()
unset(_rocprofiler_candidate_exe)
unset(_rocprofiler_candidate_ver)
unset(_rocprofiler_requested_major_minor)
endif()

if("${_VERSION}" MATCHES "^([0-9]+)\\.([0-9]+)\\.([0-9]+)$")
find_package(Python3 ${_VERSION} EXACT ${ARGN} REQUIRED MODULE
COMPONENTS ${ROCPROFILER_BUILD_Find_Python3_COMPONENTS})
Expand Down Expand Up @@ -75,6 +118,19 @@ function(get_default_python_versions _VAR)
endif()
endforeach()

# If find package doesn't find the version, but PYTHON_EXECUTABLES is passed in, add
# it to version list
if(DEFINED ROCPROFILER_PYTHON_EXECUTABLES)
foreach(_EXE IN LISTS ROCPROFILER_PYTHON_EXECUTABLES)
rocprofiler_get_python_executable_version("${_EXE}" _EXE_VER)
if(_EXE_VER AND NOT "${_EXE_VER}" IN_LIST _PYTHON_FOUND_VERSIONS)
list(APPEND _PYTHON_FOUND_VERSIONS "${_EXE_VER}")
endif()
endforeach()
unset(_EXE)
unset(_EXE_VER)
endif()

# If none found, do one last check for 3.6 (no EXACT)
if(NOT _PYTHON_FOUND_VERSIONS)
find_package(Python3 3.6 COMPONENTS ${ROCPROFILER_BUILD_Find_Python3_COMPONENTS})
Expand Down
Loading