Skip to content

fix(rocprofiler-sdk): Add timestamps to thread trace shader data - #10050

Merged
ApoKalipse-V merged 1 commit into
developfrom
users/gbaraldi/addtimestamptotrace
Sep 29, 2026
Merged

ApoKalipse-V merged 1 commit into
developfrom
users/gbaraldi/addtimestamptotrace

Conversation

@ApoKalipse-V

Copy link
Copy Markdown
Contributor

Motivation

Thread trace shader callbacks need timestamps in GPU and Sys clock for proper correlation with API tracing.

JIRA ID : ROCM-26029

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocprofiler-sdk/source/include/rocprofiler-sdk/experimental/thread-trace/core.h, projects/rocprofiler-sdk/source/lib/aqlprofile/aql_profile_v2.h, projects/rocprofiler-sdk/source/lib/aqlprofile/core/threadtrace.cpp, projects/rocprofiler-sdk/source/lib/aqlprofile/pm4/cmd_builder.h, projects/rocprofiler-sdk/source/lib/aqlprofile/pm4/gfx10_cmd_builder.h (+14 more); no test file found
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@ApoKalipse-V
ApoKalipse-V force-pushed the users/gbaraldi/addtimestamptotrace branch 2 times, most recently from e843fb1 to 0c477d0 Compare August 18, 2026 08:41

@meserve-amd meserve-amd left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor review comments a few questions for my edification, looks good otherwise.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Report

Code Coverage Report

Tests Only

code coverage tests.png

Samples Only

code coverage samples.png

Tests + Samples

code coverage all.png

@ApoKalipse-V
ApoKalipse-V force-pushed the users/gbaraldi/addtimestamptotrace branch 2 times, most recently from 063bb97 to d638451 Compare September 21, 2026 14:12
@ApoKalipse-V
ApoKalipse-V force-pushed the users/gbaraldi/addtimestamptotrace branch from d638451 to 6ec9875 Compare September 28, 2026 17:09
@ApoKalipse-V
ApoKalipse-V merged commit ac95d8d into develop Sep 29, 2026
226 of 232 checks passed
@ApoKalipse-V
ApoKalipse-V deleted the users/gbaraldi/addtimestamptotrace branch September 29, 2026 14:05
@systems-assistant

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants