Repository navigation
Add approved SQ/GL1C/GRBM/TA/TCP counters for gfx1150-1153 - #10041
Merged
vipangul merged 5 commits intoAug 24, 2026
Merged
Conversation
AIESW-38547: add approved SQ/GL1C/GRBM/TA/TCP counters for gfx1150-1153, validated on gfx1151 hardware. - 10 SQ + 4 GL1C occupancy/stall/request counters - 1 GRBM + 11 TA texture-addresser counters - TCP_TA_REQ (new) and TCP_PENDING_STALL_CYCLES (gfx11.5 definition) Event IDs verified against the gfx11.5 RDL; TCP events pinned on hardware because soc21_enum.h is off-by-one from RDL/HW in the TCP high region. Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
…-approved-gfx115-pmc
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
Wrap long description lines for the added gfx11.5 PMCs to satisfy the rocprofiler-sdk config_yaml formatting CI check (source/scripts/format-deps.py --counter-config). Co-authored-by: Cursor <cursoragent@cursor.com>
vipangul
changed the title
ApoKalipse-V
approved these changes
Aug 18, 2026
ApoKalipse-V
left a comment
ApoKalipse-V
left a comment
Contributor
There was a problem hiding this comment.
I have a single concern.
@Sushma1203 can you take a look on it?
Removed redundant GRBM_TCP_BUSY normalized Perf_Windowing wording Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
Sushma1203
approved these changes
Aug 21, 2026
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
cmcknigh
pushed a commit
that referenced
this pull request
Aug 25, 2026
## Summary JIRA ID: AIESW-38547 Approval via - DEGFX11-14512 DEGFX11-14513 DEGFX11-14514 Add approved gfx11.5 (RDNA 3.5) performance counters in `config.yaml` for gfx1150-1153: - 10 SQ (VALU/VMEM stall, wait, bus) + 4 GL1C (read-size, arb level) - 1 GRBM (TCP_BUSY) + 11 TA (addresser/aligner/write-path/flat/store/vmem) - TCP_TA_REQ (new) + gfx11.5 definition added to TCP_PENDING_STALL_CYCLES ## Validation (gfx1151) - All event IDs cross-checked against the gfx11.5 RDL (23/23 exact where the RDL is explicit; GL1C/GRBM corroborated via soc21 + hardware). - Collected via rocprofv3 on synthetic HIP kernels and a real vLLM (Qwen2.5-0.5B AWQ) inference run. Quantitative check: GL1C_REQ_READ_128B measured 4,000,016 vs 4,000,000 expected. - TCP events pinned empirically (TA_REQ=2, GL1_PENDING_STALL=54); soc21_enum.h is off-by-one from the RDL/HW in the TCP high region. ## Notes - gfx1151 limitation: only one TCP-block counter can be collected per pass. --------- Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
ajanicijamd
pushed a commit
that referenced
this pull request
Aug 25, 2026
## Summary JIRA ID: AIESW-38547 Approval via - DEGFX11-14512 DEGFX11-14513 DEGFX11-14514 Add approved gfx11.5 (RDNA 3.5) performance counters in `config.yaml` for gfx1150-1153: - 10 SQ (VALU/VMEM stall, wait, bus) + 4 GL1C (read-size, arb level) - 1 GRBM (TCP_BUSY) + 11 TA (addresser/aligner/write-path/flat/store/vmem) - TCP_TA_REQ (new) + gfx11.5 definition added to TCP_PENDING_STALL_CYCLES ## Validation (gfx1151) - All event IDs cross-checked against the gfx11.5 RDL (23/23 exact where the RDL is explicit; GL1C/GRBM corroborated via soc21 + hardware). - Collected via rocprofv3 on synthetic HIP kernels and a real vLLM (Qwen2.5-0.5B AWQ) inference run. Quantitative check: GL1C_REQ_READ_128B measured 4,000,016 vs 4,000,000 expected. - TCP events pinned empirically (TA_REQ=2, GL1_PENDING_STALL=54); soc21_enum.h is off-by-one from the RDL/HW in the TCP high region. ## Notes - gfx1151 limitation: only one TCP-block counter can be collected per pass. --------- Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JIRA ID: AIESW-38547
Approval via -
DEGFX11-14512
DEGFX11-14513
DEGFX11-14514
Add approved gfx11.5 (RDNA 3.5) performance counters in
config.yamlfor gfx1150-1153:Validation (gfx1151)
RDL is explicit; GL1C/GRBM corroborated via soc21 + hardware).
(Qwen2.5-0.5B AWQ) inference run. Quantitative check: GL1C_REQ_READ_128B
measured 4,000,016 vs 4,000,000 expected.
is off-by-one from the RDL/HW in the TCP high region.
Notes