Repository navigation
fix(rocsparse): Fix SpMM batching with COO segmented algorithm when batch count >65536 - #9975
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9975 +/- ##
=========================================
Coverage 68.93% 68.93%
=========================================
Files 2762 2762
Lines 455032 454929 -103
Branches 67118 67108 -10
=========================================
- Hits 313654 313605 -49
+ Misses 118446 118392 -54
Partials 22932 22932
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
ntrost57
approved these changes
Aug 3, 2026
kliegeois
approved these changes
Aug 3, 2026
… spmm_batched_coo_seg2
… spmm_batched_coo_seg2
… spmm_batched_coo_seg2
…ocm-libraries into spmm_batched_coo_seg2
dso-amd
reviewed
Aug 5, 2026
dso-amd
approved these changes
Aug 5, 2026
dso-amd
left a comment
dso-amd
left a comment
Contributor
There was a problem hiding this comment.
LGTM (see my suggested changes).
… spmm_batched_coo_seg2
… spmm_batched_coo_seg2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently we use the y grid dimension to perform batch computation with SpMM COO segmented algorithm. This means that if the number of batches exceeds 65535 we will get launch errors. This PR fixes that by looping over the batch count in blocks of 32768 batches.
JIRA ID: AISPARSE-606