Skip to content

feat(rocke): Add missing target intrinsics and llvm23 support #9583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tenpercent merged 11 commits into from
Jul 30, 2026
Merged

feat(rocke): Add missing target intrinsics and llvm23 support #9583

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0841d07
(rocke): black/clang formatting
yraparti Jul 17, 2026
3b50def
address review comments
yraparti Jul 21, 2026
56006f3
updated golden hash for llvn23
yraparti Jul 28, 2026
f19a5b0
address review comments on tests, added c++ parity for 24 new intrins…
yraparti Jul 29, 2026
5bb9126
fix invalid IR in the LLVM 23 intrinsic lowerings; add cross-engine p…
yraparti Jul 29, 2026
6efd67e
black format
yraparti Jul 29, 2026
cc8de62
Merge branch 'develop' into users/yraparti/rocke/llvm23_flavor_support
tenpercent Jul 29, 2026
130e0d2
fix windows CI failure
yraparti Jul 30, 2026
d395adf
remove non-ascii characters
yraparti Jul 30, 2026
45974c8
Merge branch 'develop' into users/yraparti/rocke/llvm23_flavor_support
tenpercent Jul 30, 2026
ce0328b
fix(rocke): repair merge fallout in the rocKE test tree
tenpercent Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions dnn-providers/hip-kernel-provider/rocke/platform/cpp/bindings/rocke_engine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3269,9 +3269,10 @@ std::string lower_serialized_ir(const std::string& ir_text,
}
const char* a = arch.empty() ? "gfx950" : arch.c_str();

/* flavor: "" => AUTO (resolve from env / ROCm version); "llvm20"/"llvm22"
* pin the intrinsic declaration shape. An unrecognised non-empty flavor is
* rejected so callers get the same hard error the Python lowerer raises. */
/* flavor: "" => AUTO (resolve from env / ROCm version);
* "llvm20"/"llvm22"/"llvm23" pin the intrinsic declaration shape. An
* unrecognised non-empty flavor is rejected so callers get the same hard
* error the Python lowerer raises. */
rocke_llvm_flavor_t fl = ROCKE_LLVM_FLAVOR_AUTO;
if(!flavor.empty())
{
Expand All @@ -3280,7 +3281,7 @@ std::string lower_serialized_ir(const std::string& ir_text,
{
throw std::runtime_error(
std::string("rocke_engine.lower_serialized_ir: unknown LLVM flavor '") + flavor
+ "' (expected 'llvm20' or 'llvm22')");
+ "' (expected 'llvm20', 'llvm22', or 'llvm23')");
}
}

Expand Down Expand Up @@ -3359,7 +3360,7 @@ PYBIND11_MODULE(rocke_engine, m)
"Parse serialized ck.dsl.ir/v1 text and lower it to AMDGPU LLVM IR "
"(.ll) text via the C++ engine. Family-agnostic; byte-identical to "
"the Python lowerer for the same serialized IR. flavor='' resolves "
"the LLVM flavor automatically; 'llvm20'/'llvm22' pin it.");
"the LLVM flavor automatically; 'llvm20'/'llvm22'/'llvm23' pin it.");

m.def("gemm_lower_llvm",
&gemm_lower_llvm,
Expand Down
38 changes: 38 additions & 0 deletions dnn-providers/hip-kernel-provider/rocke/platform/cpp/core/ir/core_types.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,6 +543,8 @@ static const char* const rocke_opcode_names[ROCKE_OP__COUNT] = {
"tile.global_load_lds",
"tile.async_buffer_load_lds",
"tile.async_buffer_load_lds_addr",
"tile.buffer_load_lds_async",
"tile.global_load_async_to_lds",
"tile.buffer_rsrc",
"tile.buffer_load_f16",
"tile.buffer_load_vN_f16",
Expand Down Expand Up @@ -573,6 +575,18 @@ static const char* const rocke_opcode_names[ROCKE_OP__COUNT] = {
"tile.ds_bpermute",
"tile.ds_bpermute_b64",
"tile.ds_swizzle_xor",
"tile.ds_swizzle",
"tile.mov_dpp8",
"tile.wave_reduce",
"tile.readlane",
"tile.writelane",
"tile.permlane16",
"tile.permlane64",
"tile.alignbyte",
"tile.s_wqm",
"tile.av_load_b128",
"tile.av_store_b128",
"tile.s_alloc_vgpr",
"tile.mov_dpp",
"tile.permlane32_swap",
"tile.perm_b32",
Expand All @@ -588,6 +602,11 @@ static const char* const rocke_opcode_names[ROCKE_OP__COUNT] = {
"tile.sync_lds_only",
"tile.s_barrier_bare",
"tile.s_waitcnt",
"tile.s_wait_asynccnt",
"tile.asyncmark",
"tile.wait_asyncmark",
"tile.s_wait_event",
"tile.s_prefetch_inst",
"tile.s_setprio",
"tile.iglp_opt",
"tile.sched_barrier",
Expand Down Expand Up @@ -750,6 +769,8 @@ static const bool rocke_opcode_pure[ROCKE_OP__COUNT] = {
/* global_load_lds */ false,
/* async_buffer_load_lds */ false,
/* async_buffer_load_lds_addr */ false,
/* buffer_load_lds_async */ false,
/* global_load_async_to_lds */ false,
/* buffer_rsrc */ false,
/* buffer_load_f16 */ false,
/* buffer_load_vN_f16 */ false,
Expand Down Expand Up @@ -780,6 +801,18 @@ static const bool rocke_opcode_pure[ROCKE_OP__COUNT] = {
/* ds_bpermute */ true,
/* ds_bpermute_b64 */ false,
/* ds_swizzle_xor */ true,
/* ds_swizzle */ true,
/* mov_dpp8 */ true,
/* wave_reduce */ true,
/* readlane */ true,
/* writelane */ true,
/* permlane16 */ true,
/* permlane64 */ true,
/* alignbyte */ true,
/* s_wqm */ true,
/* av_load_b128 */ true,
/* av_store_b128 */ false,
/* s_alloc_vgpr */ false,
/* mov_dpp */ false,
/* permlane32_swap */ true,
/* perm_b32 */ true,
Expand All @@ -795,6 +828,11 @@ static const bool rocke_opcode_pure[ROCKE_OP__COUNT] = {
/* sync_lds_only */ false,
/* s_barrier_bare */ false,
/* s_waitcnt */ false,
/* s_wait_asynccnt */ false,
/* asyncmark */ false,
/* wait_asyncmark */ false,
/* s_wait_event */ false,
/* s_prefetch_inst */ false,
/* s_setprio */ false,
/* iglp_opt */ false,
/* sched_barrier */ false,
Expand Down
Loading
Loading