Skip to content

[fix] Now non-swizzled stride can be less than lda*A_col#951

Closed
mengzcai wants to merge 1 commit into
ROCm:developfrom
mengzcai:mengzcai/fix_nonSwizzle_stride
Closed

[fix] Now non-swizzled stride can be less than lda*A_col#951
mengzcai wants to merge 1 commit into
ROCm:developfrom
mengzcai:mengzcai/fix_nonSwizzle_stride

Conversation

@mengzcai
Copy link
Copy Markdown
Contributor

@mengzcai mengzcai commented Jul 30, 2025

Recreated the PR here:
#979

@mengzcai mengzcai requested a review from a team as a code owner July 30, 2025 07:26
K: [128, 129]
lda: [129, 2440]
batch_count: [1, 5]
stride_a: 0
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO:

  1. support stride_a is 0 when swizzle
  2. support arbitrary stride_a for both hipblaslt-bench and hipblaslt-test when swizzled

Comment thread projects/hipblaslt/clients/include/testing_matmul.hpp
Copy link
Copy Markdown
Contributor

@solaslin solaslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG if CI passed

minsukim-amd pushed a commit that referenced this pull request Jul 31, 2025
Bumps [rocm-docs-core](https://github.com/ROCm/rocm-docs-core) from 1.13.0 to 1.14.1.
- [Release notes](https://github.com/ROCm/rocm-docs-core/releases)
- [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md)
- [Commits](ROCm/rocm-docs-core@v1.13.0...v1.14.1)

---
updated-dependencies:
- dependency-name: rocm-docs-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

[ROCm/hipBLAS commit: 1126d87]
@mengzcai mengzcai closed this Jul 31, 2025
@mengzcai mengzcai deleted the mengzcai/fix_nonSwizzle_stride branch July 31, 2025 06:29
solaslin pushed a commit that referenced this pull request Aug 5, 2025
previous PR: #951



�[0;32m[----------] �[mGlobal test environment tear-down
�[0;32m[==========] �[m55160 tests from 11 test suites ran. (2725759 ms
total)
�[0;32m[ PASSED ] �[m55160 tests.
hipBLASLt version: 100100
hipBLASLt git version:
fa94dd4
command line:
./rocm-libraries/projects/hipblaslt/build/release/clients/staging/hipblaslt-test
--gtest_output=xml --gtest_color=yes --gtest_repeat=1

Co-authored-by: mengzcai <mengzcai@amd.com>
assistant-librarian Bot pushed a commit to ROCm/hipBLASLt that referenced this pull request Aug 5, 2025
[fix] Now non-swizzled stride can be less than lda*A_col
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

previous PR: ROCm/rocm-libraries#951

�[0;32m[----------] �[mGlobal test environment tear-down
�[0;32m[==========] �[m55160 tests from 11 test suites ran. (2725759 ms
total)
�[0;32m[ PASSED ] �[m55160 tests.
hipBLASLt version: 100100
hipBLASLt git version:
ROCm/rocm-libraries@fa94dd4
command line:
./rocm-libraries/projects/hipblaslt/build/release/clients/staging/hipblaslt-test
--gtest_output=xml --gtest_color=yes --gtest_repeat=1

Co-authored-by: mengzcai <mengzcai@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants