Repository navigation
revert(ck): magic division for long_index_t - #8983
Merged
Merged
Conversation
This reverts commit c25787b.
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
bartekxk
changed the title
bartekxk
enabled auto-merge (squash)
July 2, 2026 23:07
shumway
approved these changes
Jul 2, 2026
shumway
left a comment
shumway
left a comment
Contributor
There was a problem hiding this comment.
Approved. It looks like you are changing one line in one extra file (test/grouped_convnd_bwd_data.cpp). The commit you are reverting only has four files.
assistant-librarian Bot
pushed a commit
to ROCm/composable_kernel
that referenced
this pull request
Jul 2, 2026
revert(ck): magic division for long_index_t This reverts commit c25787bf08274860e3cdd9197cd88b161752b567. ## Motivation Memfaults problems after this implementation. ## Technical Details revert magic division for large tensors. Return to standard division path ## Test Plan test_grouped_convnd_bwd_data ## Test Result passed ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. JIRA ID : ROCM-27282 JIRA ID : ROCM-27360
marbre
pushed a commit
that referenced
this pull request
Jul 7, 2026
Cherry-picks commit 80c884a into the 7.14 release branch. --- This reverts commit c25787b. ## Motivation ## Memfaults problems after this implementation. ## Technical Details ## revert magic division for large tensors. Return to standard division path ## Test Plan ## test_grouped_convnd_bwd_data ## Test Result ## passed ## Submission Checklist ## - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. JIRA ID : ROCM-27282 JIRA ID : ROCM-27360 Co-authored-by: Bartłomiej Kocot <barkocot@amd.com>
shumway
pushed a commit
to ROCm/composable_kernel
that referenced
this pull request
Aug 18, 2026
revert(ck): magic division for long_index_t This reverts commit c25787bf08274860e3cdd9197cd88b161752b567. ## Motivation Memfaults problems after this implementation. ## Technical Details revert magic division for large tensors. Return to standard division path ## Test Plan test_grouped_convnd_bwd_data ## Test Result passed ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. JIRA ID : ROCM-27282 JIRA ID : ROCM-27360
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c25787b.
Motivation
Memfaults problems after this implementation.
Technical Details
revert magic division for large tensors. Return to standard division path
Test Plan
test_grouped_convnd_bwd_data
Test Result
passed
Submission Checklist
JIRA ID : ROCM-27282
JIRA ID : ROCM-27360