Skip to content

rocthrust: fall back to bundled SQLite when system package is unsuitable - #8956

Closed
jainprad wants to merge 1 commit into
ROCm:developfrom
jainprad:users/jainprad/rocthrust-sqlite-fallback
Closed

rocthrust: fall back to bundled SQLite when system package is unsuitable#8956
jainprad wants to merge 1 commit into
ROCm:developfrom
jainprad:users/jainprad/rocthrust-sqlite-fallback

Conversation

@jainprad

@jainprad jainprad commented Jun 30, 2026

Copy link
Copy Markdown

Summary

  • When SQLITE_USE_SYSTEM_PACKAGE is ON, rocThrust did a REQUIRED find_package(SQLite3 3.51.3) and hard-failed configure if a suitable system SQLite3 was not found.
  • Make the lookup non-REQUIRED (QUIET) and fall back to the existing bundled SQLite download path when a suitable system package is not found.

Why

Some environments provide a SQLite3 CMake config that reports an unknown/incompatible version (e.g. TheRock's sysdeps-provided SQLite3), which makes find_package(... REQUIRED) fail and breaks the rocThrust (PRIM group) configure. rocThrust already supports a local download fallback (SQLITE_USE_SYSTEM_PACKAGE=OFF); this just makes the system-package path resilient instead of fatal.

Context

Split out of #8656 per review feedback (out-of-scope for that PR).

Test plan

  • Configure with a suitable system SQLite3 present → uses system package (unchanged behavior).
  • Configure where system SQLite3 is missing/unsuitable → falls back to bundled download instead of failing.

Made with Cursor

@jainprad @cursoragent
rocthrust: fall back to bundled SQLite when system package is unsuitable
b368d8f 
When SQLITE_USE_SYSTEM_PACKAGE is ON, rocThrust did a REQUIRED
find_package(SQLite3 3.51.3) and hard-failed configure if no suitable system
SQLite3 was found. Some environments provide a SQLite3 CMake config that
reports an unknown/incompatible version (e.g. TheRock's sysdeps), which breaks
the build. Make the lookup non-REQUIRED and fall back to the existing bundled
SQLite download path when a suitable system package is not found.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jainprad
jainprad requested a review from a team as a code owner June 30, 2026 10:48
jainprad added a commit to jainprad/rocm-libraries that referenced this pull request Jun 30, 2026
@jainprad @cursoragent
move codecov flag and rocThrust SQLite fallback to separate PRs
69b3ed3 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: ROCm#8955
- rocThrust SQLite fallback: ROCm#8956

Note: the header-only (PRIM group) coverage build here depends on ROCm#8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
@therock-pr-bot

therock-pr-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
🌿 Branch Name ✅ Pass —
📝 PR Title/Description ❌ Fail Error: Title does not follow Conventional Commits style.
Expected: start with a valid type (feat, fix, docs, …).
Desired format: type(optional-scope): short description
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Title/Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

@therock-pr-bot

therock-pr-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Title/Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

jainprad added a commit to jainprad/rocm-libraries that referenced this pull request Jul 21, 2026
@jainprad @cursoragent
move codecov flag and rocThrust SQLite fallback to separate PRs
c5438bd 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: ROCm#8955
- rocThrust SQLite fallback: ROCm#8956

Note: the header-only (PRIM group) coverage build here depends on ROCm#8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
reboss pushed a commit that referenced this pull request Jul 21, 2026
@jainprad @cursoragent @reboss
move codecov flag and rocThrust SQLite fallback to separate PRs
8769fa3 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: #8955
- rocThrust SQLite fallback: #8956

Note: the header-only (PRIM group) coverage build here depends on #8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
jainprad added a commit to jainprad/rocm-libraries that referenced this pull request Jul 21, 2026
@jainprad @cursoragent
move codecov flag and rocThrust SQLite fallback to separate PRs
867a041 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: ROCm#8955
- rocThrust SQLite fallback: ROCm#8956

Note: the header-only (PRIM group) coverage build here depends on ROCm#8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
reboss pushed a commit that referenced this pull request Jul 23, 2026
@jainprad @cursoragent @reboss
move codecov flag and rocThrust SQLite fallback to separate PRs
b022144 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: #8955
- rocThrust SQLite fallback: #8956

Note: the header-only (PRIM group) coverage build here depends on #8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
reboss pushed a commit that referenced this pull request Jul 23, 2026
@jainprad @cursoragent @reboss
move codecov flag and rocThrust SQLite fallback to separate PRs
507cc50 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: #8955
- rocThrust SQLite fallback: #8956

Note: the header-only (PRIM group) coverage build here depends on #8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
reboss pushed a commit that referenced this pull request Jul 24, 2026
@jainprad @cursoragent @reboss
move codecov flag and rocThrust SQLite fallback to separate PRs
9cc06e9 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: #8955
- rocThrust SQLite fallback: #8956

Note: the header-only (PRIM group) coverage build here depends on #8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

  • Add new commits
  • Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

@github-actions github-actions Bot added the Stale PR has no activity for 25+ days label Jul 26, 2026
reboss pushed a commit that referenced this pull request Jul 27, 2026
@jainprad @cursoragent @reboss
move codecov flag and rocThrust SQLite fallback to separate PRs
b21c2cc 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: #8955
- rocThrust SQLite fallback: #8956

Note: the header-only (PRIM group) coverage build here depends on #8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
reboss pushed a commit that referenced this pull request Jul 27, 2026
@jainprad @cursoragent @reboss
move codecov flag and rocThrust SQLite fallback to separate PRs
80eaad8 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: #8955
- rocThrust SQLite fallback: #8956

Note: the header-only (PRIM group) coverage build here depends on #8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
reboss pushed a commit that referenced this pull request Jul 29, 2026
@jainprad @cursoragent @reboss
move codecov flag and rocThrust SQLite fallback to separate PRs
77bd53a 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: #8955
- rocThrust SQLite fallback: #8956

Note: the header-only (PRIM group) coverage build here depends on #8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
reboss pushed a commit that referenced this pull request Jul 29, 2026
@jainprad @cursoragent @reboss
move codecov flag and rocThrust SQLite fallback to separate PRs
46c913f 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: #8955
- rocThrust SQLite fallback: #8956

Note: the header-only (PRIM group) coverage build here depends on #8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
reboss pushed a commit that referenced this pull request Jul 29, 2026
@jainprad @cursoragent @reboss
move codecov flag and rocThrust SQLite fallback to separate PRs
285274b 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: #8955
- rocThrust SQLite fallback: #8956

Note: the header-only (PRIM group) coverage build here depends on #8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
reboss pushed a commit that referenced this pull request Jul 29, 2026
@jainprad @cursoragent @reboss
move codecov flag and rocThrust SQLite fallback to separate PRs
3e2e484 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: #8955
- rocThrust SQLite fallback: #8956

Note: the header-only (PRIM group) coverage build here depends on #8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
reboss pushed a commit that referenced this pull request Jul 29, 2026
@jainprad @cursoragent @reboss
move codecov flag and rocThrust SQLite fallback to separate PRs
072cf5c 
Per review feedback, the codecov.yml rocPRIM flag and the rocThrust SQLite3
fallback are out-of-scope for this PR. They now live in their own PRs:
- codecov rocPRIM flag: #8955
- rocThrust SQLite fallback: #8956

Note: the header-only (PRIM group) coverage build here depends on #8956
landing so rocThrust configure does not fail on find_package(SQLite3).

Co-authored-by: Cursor <cursoragent@cursor.com>
@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed due to inactivity (30 days with no updates).

If you'd like to continue working on this, feel free to reopen the PR or create a new one.

@github-actions github-actions Bot closed this Aug 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

organization: ROCm project: rocthrust Stale PR has no activity for 25+ days

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jainprad