Skip to content

[MIOpen] Fix softmax kernel NaN failure when beta=0 (ROCM-26026) #8426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SreecharanGundaboluAMD merged 3 commits into from
Jun 17, 2026
Merged

[MIOpen] Fix softmax kernel NaN failure when beta=0 (ROCM-26026) #8426

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06cc8c1
[MIOpen] Fix softmax kernel NaN failure when beta=0 (ROCM-26026)
SreecharanGundaboluAMD Jun 15, 2026
e1c236b
clang format
SreecharanGundaboluAMD Jun 15, 2026
71e5c41
add gtests to catch regression in the future
SreecharanGundaboluAMD Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions projects/miopen/src/kernels/MIOpenSoftmax.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,8 @@ __forceinline__ __device__ void softmaxfwd(const T* __restrict__ x,
}

value = value * CVT_FP32_2ACCUM(alpha) +
CVT_FLOAT2ACCUM(y[y_idx]) * CVT_FP32_2ACCUM(beta);
(beta != 0.0f ? CVT_FLOAT2ACCUM(y[y_idx]) * CVT_FP32_2ACCUM(beta)
: FLOAT_ACCUM{0});
y[y_idx] = CVT_ACCUM2FLOAT(value);
});
}
Expand Down Expand Up @@ -386,7 +387,8 @@ __forceinline__ __device__ void softmaxfwd(const T* __restrict__ x,
}

values[v_idx] = values[v_idx] * CVT_FP32_2ACCUM(alpha) +
CVT_FLOAT2ACCUM(y[y_idx]) * CVT_FP32_2ACCUM(beta);
(beta != 0.0f ? CVT_FLOAT2ACCUM(y[y_idx]) * CVT_FP32_2ACCUM(beta)
: FLOAT_ACCUM{0});

y[y_idx] = CVT_ACCUM2FLOAT(values[v_idx]);
}
Expand Down Expand Up @@ -455,7 +457,8 @@ __forceinline__ __device__ void softmaxbwd(const T* __restrict__ y,
value = (value - channel_dot) * CVT_FLOAT2ACCUM(y[y_idx]);
}
value = value * CVT_FP32_2ACCUM(alpha) +
CVT_FLOAT2ACCUM(dx[dx_idx]) * CVT_FP32_2ACCUM(beta);
(beta != 0.0f ? CVT_FLOAT2ACCUM(dx[dx_idx]) * CVT_FP32_2ACCUM(beta)
: FLOAT_ACCUM{0});
dx[dx_idx] = CVT_ACCUM2FLOAT(value);
});
}
Expand Down Expand Up @@ -523,7 +526,8 @@ __forceinline__ __device__ void softmaxbwd(const T* __restrict__ y,
}

auto value = dy_values[index] * CVT_FP32_2ACCUM(alpha) +
CVT_FLOAT2ACCUM(dx[dx_idx]) * CVT_FP32_2ACCUM(beta);
(beta != 0.0f ? CVT_FLOAT2ACCUM(dx[dx_idx]) * CVT_FP32_2ACCUM(beta)
: FLOAT_ACCUM{0});
dx[dx_idx] = CVT_ACCUM2FLOAT(value);
}
++index;
Expand Down
Loading