Repository navigation
Conversation
…ocable For the generic 'amdgcnspirv' target the 'dpp' feature is unknown until the SPIR-V is JIT-compiled for a concrete GPU by comgr, so clang rejects the bare builtin with "cannot be invoked in the current context, as it requires the 'dpp' feature(s)". Guard it with a resolved at JIT 'if(__builtin_amdgcn_is_invocable(...))'.
Author
|
Closing in favor of #8102 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the generic 'amdgcnspirv' target the 'dpp' feature is unknown until the SPIR-V is JIT-compiled for a concrete GPU by comgr, so clang rejects the bare builtin with "cannot be invoked in the current context, as it requires the 'dpp' feature(s)". Guard it with a resolved at JIT 'if(__builtin_amdgcn_is_invocable(...))'.
More technical details:
llvm/llvm-project#134016
Other similar changes in ROCm stack:
ROCm/rocm-systems#5581
Test Result
Without the patch all related to rocPRIM rocm-examples compiled for amdgcnspirv fail with the
error mentioned above.
With the patch all rocm-examples can be compiled and pass. Same story for HeCBench samples.