Skip to content

Bump TheRock pin to 384834 (2026-06-10) - #8275

Merged
amd-justchen merged 1 commit into
developfrom
users/lpromber/bump_therock_10_june_2026
Jun 10, 2026
Merged

amd-justchen merged 1 commit into
developfrom
users/lpromber/bump_therock_10_june_2026

Conversation

@HereThereBeDragons

Copy link
Copy Markdown
Contributor

Bumps TheRock from 6e74853 to 384834.

See full commit comparison here:

ROCm/TheRock@6e74853...384834e

Fixes ROCm/TheRock#5742

@HereThereBeDragons
HereThereBeDragons requested a review from a team as a code owner June 10, 2026 17:12
@github-actions github-actions Bot added the project: none Does not target any component label Jun 10, 2026
@archana-ramalingam

archana-ramalingam commented Jun 10, 2026 •

Copy link
Copy Markdown
Contributor

We will need this fix to actually trigger the respective CI tests on this bump PR - #8249
cc: @tony-davis

@HereThereBeDragons

Copy link
Copy Markdown
Contributor Author

ci run to build all projects: https://github.com/ROCm/rocm-libraries/actions/runs/27293674604

@amd-justchen

Copy link
Copy Markdown
Contributor

ci run to build all projects: https://github.com/ROCm/rocm-libraries/actions/runs/27293674604

Waiting for this to finish just in case, but from the cross repo ci checks mentioned in this pr comment ROCm/TheRock#5748 (comment). It looks like it was working.

@marbre marbre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marbre

marbre commented Jun 10, 2026

Copy link
Copy Markdown
Member

@geomin12 @jayhawk-commits do you want to approve on behalf of libraries-reviewers?

@amd-justchen

Copy link
Copy Markdown
Contributor

Looks like non-prolense runners are passing!
https://github.com/ROCm/rocm-libraries/actions/runs/27293674604/job/80661756727#step:1:2
Runner name: 'windows-strix-halo-gpu-rocm-6'

https://github.com/ROCm/rocm-libraries/actions/runs/27293674604/job/80661756702#step:1:2
Runner name: 'windows-strix-halo-gpu-rocm-2'

https://github.com/ROCm/rocm-libraries/actions/runs/27293674604/job/80661756675#step:1:2
Runner name: 'windows-strix-halo-gpu-rocm-1'

https://github.com/ROCm/rocm-libraries/actions/runs/27293674604/job/80661756453#step:1:2
Runner name: 'CS-RORDMZ-DT240'

With everything passing and just the known long paths problem, I will go ahead an approve and merge this.

@amd-justchen
amd-justchen merged commit fc086e7 into develop Jun 10, 2026
121 of 126 checks passed
@amd-justchen
amd-justchen deleted the users/lpromber/bump_therock_10_june_2026 branch June 10, 2026 23:23
cderb pushed a commit that referenced this pull request Jun 12, 2026
Bumps TheRock from `6e74853` to `384834`.

See full commit comparison here:


ROCm/TheRock@6e74853...384834e


Fixes ROCm/TheRock#5742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

organization: ROCm project: none Does not target any component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Issue] Error: fatal: No url found for submodule path ... in .gitmodules during TheRock CI jobs in rocm-libraries

4 participants