Skip to content

[MIOpen] Fix SoftMarginLossForward reduce kernel kernarg corruption (#8065) #8135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JonathanLichtnerAMD merged 1 commit into from
Jun 8, 2026
Merged

[MIOpen] Fix SoftMarginLossForward reduce kernel kernarg corruption (#8065) #8135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions projects/miopen/src/solver/softmarginloss/forward_softmarginloss.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,23 +235,23 @@ ConvSolution SoftMarginLossForward::GetSolution(
size = (size + LOCAL_SIZE_REDUCE - 1) / LOCAL_SIZE_REDUCE;
}

// The final ReduceSum kernel signature takes tensor_view_t<1>; passing the
// 5D o_tv would corrupt the kernarg buffer (80B written into 16B slot).
auto o_tv_1d = get_inner_expanded_tv<1>(deref(params.oDesc));
decltype(auto) kernel = handle_.Run(kernels[kernelCnt]);
kernel(reduce_in, params.o, size, o_tv);
kernel(reduce_in, params.o, size, o_tv_1d);
Comment thread
JonathanLichtnerAMD marked this conversation as resolved.
Resolved

if(profiling)
{
(void)hipEventRecord(stop.get(), handle_.GetStream());
(void)hipEventSynchronize(stop.get());
(void)hipEventElapsedTime(&elapsed, start.get(), stop.get());

// Clean up
(void)hipEventDestroy(start.get());
(void)hipEventDestroy(stop.get());
handle_.ResetKernelTime();
handle_.AccumKernelTime(elapsed);

handle_.EnableProfiling(true);
};
}
};
};
}
Expand Down
Loading