Repository navigation
feat(tensilelite): Add pre-submit GPU emulation dispatch workflow - #8004
Closed
archana-ramalingam wants to merge 2 commits into
Closed
archana-ramalingam wants to merge 2 commits into
archana-ramalingam wants to merge 2 commits into
Conversation
github-actions
Bot
added
github actions
project: none
archana-ramalingam
marked this pull request as draft
June 3, 2026 06:25
geomin12
reviewed
Jun 5, 2026
archana-ramalingam
marked this pull request as ready for review
June 9, 2026 02:36
archana-ramalingam
added a commit
that referenced
this pull request
Jun 9, 2026
…o PR #8004 These changes belong with the GPU emulation dispatch work, not the CI matrix enablement PR. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #8004 +/- ##
===========================================
- Coverage 65.18% 65.18% -0.00%
===========================================
Files 2597 2597
Lines 404525 404613 +88
Branches 60261 60281 +20
===========================================
+ Hits 263670 263721 +51
- Misses 121057 121082 +25
- Partials 19798 19810 +12
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
archana-ramalingam
force-pushed
the
users/aramalin/gpu-emu-presubmit
branch
from
June 11, 2026 10:39
4a18381 to
428a40e
Compare
6 tasks done
archana-ramalingam
added a commit
to ROCm/TheRock
that referenced
this pull request
Jun 15, 2026
…5590) ## Summary Extend TensileLite test infrastructure to support gfx1250 common GEMM tests under GPU emulation, building on the test component foundation from #5529. ## Technical details - `test_tensilelite.py`: - Add `UNIT_TEST_SKIP_FAMILIES` set for arch-gated unit test skipping (currently `gfx1250`) - Add gfx1250 common GEMM test section to `test_tensilelite.py` - Use `-m "gfx1250 or gfx12" -k gfx1250` to select tests from both `gfx1250/` directories and `gemm/gfx12/*gfx1250*` files - Honor `TEST_PROFILE` env var: `default` runs curated 57-test subset (~17 min), `nightly` runs all gfx1250 tests - Add `lib/llvm/lib` to `LD_LIBRARY_PATH` (fixes `libomp.so` load failure for `tensilelite-client`) - `FFM_QUICK_INCLUDE`: 57 curated tests with `.yaml` suffix patterns and path prefixes for disambiguation - `CMakeLists.txt`: Enable `TENSILELITE_ENABLE_CLIENT` on Linux only (Windows MSVC has pre-existing `DataInitialization.hpp` compilation issues) - Add `libexec/hipblaslt/tensilelite/**` to `artifact-blas.toml` test component ## Linked PRs - Companion rocm-libraries PR: [ROCm/rocm-libraries#8004](ROCm/rocm-libraries#8004) — client install rule + `makeIsaInfoMap` fixture fix + xfail marks for 5 known-failing streamk tests ## Test plan - [x] CI build passes (existing tensilelite tests unaffected — common test section is a no-op without gfx1250 emulator) - [x] Windows build passes (client build disabled on Windows) - [x] gfx1250 emulation run: `tensilelite-client` launches without `libomp.so` errors - [x] Quick subset selects exactly 57 tests, no ambiguous `-k` matches ## Test results - [x] 78/83 gfx1250 tests pass, 5 streamk MX tests xfail'd (solution validation regression) - [x] Quick subset: 57 tests in 16:50, timing consistent across 5 iterative runs AIHPBLAS-3508 Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
The 5 StreamK MX tests are marked as |
geomin12
reviewed
Jun 16, 2026
geomin12
left a comment
geomin12
left a comment
Collaborator
There was a problem hiding this comment.
i see that the CI trigger isn't running? we should also add this CI into here:
also, let's keep the PR scoped to only .github/workflows/tensilelite-ffm-ci.yml. the other files should be in a separate PR
geomin12
reviewed
Jun 16, 2026
geomin12
left a comment
geomin12
left a comment
Collaborator
There was a problem hiding this comment.
CI was skipped, not sure why?
This was referenced Jun 16, 2026
Merged
- New workflow tensilelite-ffm-ci.yml: dispatches gfx1250 emulation tests on TensileLite PRs via external CI - Register tensilelite-* in GITHUB_WORKFLOWS_CI_PATTERNS - Uses git diff path check (no third-party actions) - No paths: trigger filter (compatible with required checks) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
archana-ramalingam
force-pushed
the
users/aramalin/gpu-emu-presubmit
branch
from
June 16, 2026 23:18
2a5c3af to
a92bf1a
Compare
archana-ramalingam
changed the title
Contributor
Author
|
Closing — the dispatch approach requires secrets in the public repo, which isn't permitted. FFM testing is handled via an alternative path that doesn't need public-side secrets. The |
archana-ramalingam
added a commit
that referenced
this pull request
Jun 25, 2026
…singleton poisoning (#8520) ## Motivation Split from PR #8004 per reviewer request. These changes are prerequisites for GPU emulation testing on gfx1250. ## Technical Details - `CMakeLists.txt`: Install `tensilelite-client` to `libexec/hipblaslt/tensilelite` when the target exists. Required for FFM emulation tests to locate the prebuilt client binary. - `test_MatrixInstructionConversion.py`: Move `validateToolchain()` and `makeIsaInfoMap()` from module level to `@pytest.fixture(scope="module")`. Prevents rocisa singleton poisoning when unit and common test modules are collected in the same pytest session. ## Test Plan - [x] CI build passes (tensilelite-client install is conditional on target existence) - [x] TensileLite unit tests pass (fixture change is backwards-compatible) ## Test Result - [x] Both changes validated in FFM CI runs (78/83 gfx1250 tests pass) ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. JIRA ID: AIHPBLAS-3508 --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a GitHub Actions workflow that dispatches gfx1250 common GEMM tests on GPU emulation for the PR pre-submits in TensileLite.
Technical details
.github/workflows/tensilelite-ffm-ci.ymlpull_requesttodevelopfor paths underprojects/hipblaslt/tensilelite/**repository_dispatchwithevent_type=psdb-triggerto an external CI repo viagh apirepo,commit,pr_number,families=gfx1250,component_list=tensileliteFeature coverage (57/83 gfx1250 tests, all kernel features)
FP16/BF16, FP32/XFP32, FP64, INT8, FP8, FP6, FP4, MX, TDM, LargeLDS, 1024VGPR, StreamK, Sparse, Gradient, Activation, Transposes
Dependency
common GEMM test support to
test_tensilelite.pyTest plan
Test results
AIHPBLAS-3508