Repository navigation
[rocRAND] Revert PR #446 (refactor(rocrand): replace hip vector accessor macro - #793
Merged
Merged
Conversation
…cro and use underlying native vector) The change reverts commit 51fed3d, which was causing some performance issues for the philox and threefry generators.
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (52.07%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #793 +/- ##
========================================
Coverage 52.07% 52.07%
========================================
Files 63 63
Lines 7438 7436 -2
Branches 810 810
========================================
- Hits 3873 3872 -1
Misses 3233 3233
+ Partials 332 331 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
stanleytsang-amd
approved these changes
Jul 23, 2025
assistant-librarian Bot
pushed a commit
to ROCm/rocRAND
that referenced
this pull request
Jul 23, 2025
[rocRAND] Revert PR #446 (refactor(rocrand): replace hip vector accessor macro (#793) Revert PR #446 (refactor(rocrand): replace hip vector accessor macro and use underlying native vector) The change reverts commit 51fed3d87c40fe5b36959857750654c03f182fd4, which was causing some performance issues for the philox and threefry generators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert PR #446 (refactor(rocrand): replace hip vector accessor macro and use underlying native vector)
The change reverts commit 51fed3d, which was causing some performance issues for the philox and threefry generators.