Skip to content

[MIOpen] Fix use-after-free of kernel_id in InitInvokerFactoryNCHW #7922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdcampbe merged 6 commits into from
Jun 8, 2026
Merged

[MIOpen] Fix use-after-free of kernel_id in InitInvokerFactoryNCHW #7922

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
efc74f8
[MIOpen] Fix use-after-free of kernel_id in InitInvokerFactoryNCHW
jdcampbe May 31, 2026
57fd4f2
Merge branch 'develop' into users/jascampb/fix-kernel-name-reference-…
jdcampbe Jun 2, 2026
63d332f
Merge branch 'develop' into users/jascampb/fix-kernel-name-reference-…
jdcampbe Jun 3, 2026
078cf07
Merge branch 'develop' into users/jascampb/fix-kernel-name-reference-…
jdcampbe Jun 4, 2026
c03effe
Merge branch 'develop' into users/jascampb/fix-kernel-name-reference-…
jdcampbe Jun 5, 2026
929e0ad
Merge branch 'develop' into users/jascampb/fix-kernel-name-reference-…
BradPepersAMD Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions projects/miopen/src/ck_impl/implicitgemm_ck_util.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -933,7 +933,7 @@ ConvSolution InitInvokerFactoryNCHW(const ExecutionContext& ctx,
internal::MakeTaggedTransposeInstances<CKArgsType>(
result, ctx, problem, ck_args, input1_op, input2_op, output_op, _ck_buff_des);

result.invoker_factory = [kernel_id_ = &kernel_id,
result.invoker_factory = [kernel_id_ = kernel_id,
Comment thread
jdcampbe marked this conversation as resolved.
Resolved
split_k_ = split_k,
ck_args_ = std::move(ck_args),
sh_conv_ptr_ = std::shared_ptr{std::move(*ptr_iter)},
Expand All @@ -943,7 +943,7 @@ ConvSolution InitInvokerFactoryNCHW(const ExecutionContext& ctx,
output_init_tr_inst_ = std::move(_output_init_tr_inst),
ck_buff_des_ =
_ck_buff_des](const std::vector<Kernel>& kernels) mutable {
return [kernel_id2 = kernel_id_,
return [kernel_id2 = std::move(kernel_id_),
split_k2 = split_k_,
kernels,
ck_args2 = std::move(ck_args_),
Expand Down Expand Up @@ -1031,7 +1031,7 @@ ConvSolution InitInvokerFactoryNCHW(const ExecutionContext& ctx,
// Kernel logging for CK kernels
if(IsLoggingKernel())
{
AddKernelToJsonAccumulator(*kernel_id2, elapsed, false);
AddKernelToJsonAccumulator(kernel_id2, elapsed, false);
}
handle.ResetKernelTime();
handle.AccumKernelTime(elapsed);
Expand Down
Loading