Repository navigation
[miopen-provider] Add test filter standardization #7901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4a0922d
[miopen-provider] Add test filter standardization
dileepr1 cdc7e48
[miopen-provider][ci] Point TheRock CI ref at users/dravindr/tr_miope…
dileepr1 5e7616b
[miopen-provider] Add Windows+gfx110X exclusion for integration tests
dileepr1 43d4ae6
[miopen-provider] Fix duplicate exclude_gpu key in test_categories.yaml
dileepr1 01e8721
Merge branch 'develop' into users/dravindr/tf_miopen_prov
dileepr1 36443d0
Merge branch 'develop' into users/dravindr/tf_miopen_prov
dileepr1 4c13fcd
miopen-provider: label external integration test via YAML and fix dou…
dileepr1 10e061f
Merge branch 'develop' into users/dravindr/tf_miopen_prov
dileepr1 1aa0935
Revert TheRock ref to develop's pinned SHA (drop tr_miopen_prov pin)
dileepr1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| # Copyright © Advanced Micro Devices, Inc., or its affiliates. | ||
| # SPDX-License-Identifier: MIT | ||
| # | ||
| # miopen-provider Test Categories Configuration | ||
| # Aligned with Test Filter Standardization (RFC0010). | ||
| # | ||
| # miopen-provider has two GTest binaries (miopen_plugin_tests and | ||
| # miopen_plugin_integration_tests) that share this YAML. Tier behaviour | ||
| # mirrors the legacy test_miopenprovider.py runner: | ||
| # - quick: GTEST_FILTER="-Full*" (skip the Full/* INSTANTIATE_TEST_SUITE_P | ||
| # parameterised expansions used by integration tests; unit tests have no | ||
| # Full* prefix so they all run) | ||
| # - comprehensive/full: run everything (including Full*) | ||
| # | ||
| # Unit tests in tests/ use INSTANTIATE_TEST_SUITE_P prefixes "AllCases" and | ||
| # bare TEST/TEST_F; integration tests in integration_tests/ use "Smoke" and | ||
| # "Full" prefixes. There are no Standard*/Comprehensive* prefixes, so the | ||
| # standard tier is the same shape as quick (matches pre-checkin scope). | ||
|
|
||
| # YAML anchor for the shared exclusion list. Mirrors the legacy filter in | ||
| # TheRock build_tools/github_actions/test_executable_scripts/test_miopenprovider.py | ||
| # (which only used GTEST_FILTER="-Full*" for quick, and *DISABLED* is the | ||
| # standard GTest convention for skipped tests). | ||
| _common_excludes: &common_excludes | ||
| - "*DISABLED*" | ||
|
|
||
| test_categories: | ||
|
dileepr1 marked this conversation as resolved.
Resolved
|
||
| quick: | ||
| description: "Fast sanity checks (target: < 5 min) - excludes Full* parameterised expansions" | ||
| test_patterns: | ||
| - "*" | ||
| exclude: | ||
| - "*DISABLED*" | ||
| - "Full*" | ||
| labels: | ||
| - "quick" | ||
| - "pre-commit" | ||
| - "smoke" | ||
|
|
||
| standard: | ||
| description: "Pre-checkin validation (target: < 45 min) - same shape as quick (no Standard* tier exists)" | ||
| test_patterns: | ||
| - "*" | ||
| exclude: | ||
| - "*DISABLED*" | ||
| - "Full*" | ||
| labels: | ||
| - "standard" | ||
| - "pr" | ||
| - "precheckin" | ||
|
|
||
| comprehensive: | ||
| description: "Nightly comprehensive tests (target: < 7 hours) - includes Full* tier" | ||
| test_patterns: | ||
| - "*" | ||
| exclude: *common_excludes | ||
| labels: | ||
| - "comprehensive" | ||
| - "nightly" | ||
| - "extended" | ||
|
|
||
| full: | ||
| description: "Complete test suite - all tests including Full*" | ||
| test_patterns: | ||
| - "*" | ||
| exclude: *common_excludes | ||
| labels: | ||
| - "full" | ||
| - "all" | ||
|
|
||
| # GPU-arch-specific exclusions. Mirrors the TEST_TO_IGNORE map in the legacy | ||
| # TheRock/build_tools/github_actions/test_executable_scripts/test_miopenprovider.py: | ||
| # | ||
| # TEST_TO_IGNORE = { | ||
| # # TODO(#3709): Re-enable gfx110X tests once issues are resolved | ||
| # "gfx110X-all": { | ||
| # "windows": ["miopen_plugin_integration_tests"], | ||
| # }, | ||
| # } | ||
| # | ||
| # The legacy carve-out is OS-scoped (Windows only). The shared parser accepts | ||
| # an optional `_windows` / `_linux` suffix on the key and skips the entire | ||
| # block when configuring on the wrong OS, so this entry never reaches the | ||
| # Linux install file. The runtime label is still `ex_gpu_gfx110X` (no OS | ||
| # suffix) so test_runner.py's GPU-arch matching needs no changes. | ||
| # | ||
| # `*Integration*` is the gtest filter that scopes the exclusion to the | ||
| # integration binary only: all TEST_P classes in integration_tests/ are named | ||
| # IntegrationGpu*, and no TEST_P class in tests/ contains "Integration". So | ||
| # the filter is a no-op on miopen_plugin_tests (unit tests still run) and a | ||
| # full exclusion on miopen_plugin_integration_tests, matching the legacy | ||
| # script's ctest --exclude-regex "miopen_plugin_integration_tests" exactly. | ||
| exclude_gpu: | ||
| exclude_gpu_gfx110X_windows: | ||
| test_patterns: | ||
| - "*Integration*" | ||
| labels: | ||
| - "quick" | ||
| - "standard" | ||
| - "comprehensive" | ||
| - "full" | ||
| - "ex_gpu_gfx110X" | ||
|
|
||
| execution_settings: | ||
| default_timeout: 300 | ||
| timeout_multiplier: 1 | ||
| category_timeouts: | ||
| quick: 300 # 5 minutes | ||
| standard: 2700 # 45 minutes | ||
| comprehensive: 25200 # 7 hours | ||
| full: 28800 # 8 hours | ||
32 changes: 32 additions & 0 deletions
32
dnn-providers/miopen-provider/test_categories_external.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # Copyright © Advanced Micro Devices, Inc., or its affiliates. | ||
| # SPDX-License-Identifier: MIT | ||
| # | ||
| # miopen-provider External Integration Test Categories (RFC0010). | ||
| # | ||
| # Separate from test_categories.yaml: this drives apply_ctest_category_labels() | ||
| # over the pre-registered CTest test `miopen-provider-external-integration-check` | ||
| # (patterns match CTest test NAMES), whereas test_categories.yaml drives | ||
| # apply_test_category_labels() over GTest binaries (patterns are GTest globs). | ||
| # | ||
| # Placed in the quick tier so it runs in every category (quick -> standard -> | ||
| # comprehensive -> full), matching the legacy test_miopenprovider.py which ran | ||
| # ctest with no label filter (the test executed in all TEST_TYPEs). | ||
| # | ||
| # `labels:` must carry the COMPLETE set (tier labels + descriptive/engine | ||
| # labels) because apply_ctest_category_labels() emits one replacing | ||
| # set_tests_properties(); anything omitted is lost in the install tree. | ||
|
|
||
| test_categories: | ||
| quick: | ||
| description: "Cross-provider integration suite against the miopen plugin (slow)" | ||
| test_patterns: | ||
| - "miopen-provider-external-integration-check" | ||
| labels: | ||
| - "quick" | ||
| - "standard" | ||
| - "comprehensive" | ||
| - "full" | ||
| - "integration_test" | ||
| - "slow" | ||
| - "external_integration_test" | ||
| - "MIOPEN_ENGINE" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.