Skip to content

[tensilelite] Fix test_PlaceholderMerge xfail for TheRock CI #7716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
archana-ramalingam merged 2 commits into from
May 26, 2026
Merged

[tensilelite] Fix test_PlaceholderMerge xfail for TheRock CI #7716

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4df9a4
[tensilelite] Fix test_PlaceholderMerge xfail for install-tree enviro…
archana-ramalingam May 23, 2026
c076753
Merge branch 'develop' into users/aramalin/tensilelite-therock-ci-2
archana-ramalingam May 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion projects/hipblaslt/tensilelite/Tensile/Tests/unit/test_PlaceholderMerge.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
/ "Tensile" / "Logic" / "asm_full"
)

pytestmark = pytest.mark.xfail(
_needs_logic_dir = pytest.mark.xfail(
not _LOGIC_ROOT.is_dir(),
reason="Logic files not found: https://github.com/ROCm/rocm-libraries/issues/7481",
)
Expand Down Expand Up @@ -90,6 +90,7 @@ def _read_device_names(yaml_path: Path):
return None


@_needs_logic_dir
def test_logic_yaml_sibling_device_names_consistent():
"""Same-basename YAMLs in one arch dir must declare identical DeviceNames."""
assert _LOGIC_ROOT.is_dir(), f"Logic root not found: {_LOGIC_ROOT}"
Expand Down Expand Up @@ -199,6 +200,7 @@ def test_hardware_gates_placeholder_chip_id_suffix(
assert placeholderName.endswith("_" + devicePart), placeholderName


@_needs_logic_dir
@pytest.mark.parametrize("arch", _all_arch_names())
def test_supports_chip_id_predicate_only_gfx950(arch):
"""Lock chip-id-aware archs to gfx950; new entries require re-audit of
Expand Down
Loading