[P3-2] Remove dqdkdv_dev.hpp:105-107 d128 static_assert; dispatch via if constexpr - #7638
Merged
Conversation
chris-tsiaousis-hpc
changed the title
chris-tsiaousis-hpc
marked this pull request as ready for review
May 22, 2026 15:37
chris-tsiaousis-hpc
force-pushed
the
users/chris-tsiaousis-hpc/ck/rocm-ck-p3-2-remove-static-assert
branch
from
May 28, 2026 07:53
a281e20 to
e6e0f78
Compare
chris-tsiaousis-hpc
changed the base branch from
users/shumway/ck/exp-kpack
to
users/chris-tsiaousis-hpc/ck/rocm-ck-p3-1-tile-config
May 28, 2026 08:00
chris-tsiaousis-hpc
force-pushed
the
users/chris-tsiaousis-hpc/ck/rocm-ck-p3-2-remove-static-assert
branch
from
May 28, 2026 08:01
e6e0f78 to
6123540
Compare
Signed-off-by: Chris Tsiaousis <chris.tsiaousis@streamhpc.com>
Address review findings on the P3-2 frozen-baseline / consteval canary layer. Comment-and-test-only; no production logic changes. - Fix NOTE citing non-existent GFX9_FP16_DQDKDV_TILES (correct symbol is GFX9_FP16_DQDKDV_BASE_TILES). - Clarify that the OGradDotO/ConvertDQ "multi-hdim" tests assert hdim-invariant constants, not per-hdim geometry coverage. - Reword NOTEs/canary comments that over-claimed: baselines are compile-time spec-factory checks (not runtime numerical validation), and the canary guards block_n0 only (not full tile geometry). - Add asymmetric-hdim DqDkDv coverage (D64Q_D256V, D256Q_D64V) to exercise the max(hdim_q, hdim_v) lookup; (64,256) is discriminating. - Add the missing d128 block_n0 static_assert canary so the block now covers all five hdims. Verified: standalone host compile passes; compat suite 65/65 PASS; clang-format clean. Signed-off-by: Adam Osewski <Adam.Osewski@amd.com> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
aosewski
force-pushed
the
users/chris-tsiaousis-hpc/ck/rocm-ck-p3-2-remove-static-assert
branch
from
June 1, 2026 12:00
0f1f86f to
9c9391d
Compare
aosewski
merged commit Jun 1, 2026
47c39a9
into
users/chris-tsiaousis-hpc/ck/rocm-ck-p3-1-tile-config
2 of 5 checks passed
aosewski
deleted the
users/chris-tsiaousis-hpc/ck/rocm-ck-p3-2-remove-static-assert
branch
June 1, 2026 12:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7560
Note: Part of it was done in
#7506