Skip to content

[hipCUB][Code Coverage][Cherry Pick] Increase hipCUB code coverage#757

Closed
NguyenNhuDi wants to merge 4 commits into
ROCm:release/rocm-rel-7.0from
NguyenNhuDi:zenguyen-hipcub/increase-code-coverage-cherry-pick-7.0
Closed

[hipCUB][Code Coverage][Cherry Pick] Increase hipCUB code coverage#757
NguyenNhuDi wants to merge 4 commits into
ROCm:release/rocm-rel-7.0from
NguyenNhuDi:zenguyen-hipcub/increase-code-coverage-cherry-pick-7.0

Conversation

@NguyenNhuDi
Copy link
Copy Markdown
Contributor

No description provided.

Re making PR ROCm#172 to merge to develop instead of release-staging
`->` was used instead of `.` for non pointer arrays.
NguyenNhuDi and others added 2 commits August 1, 2025 08:23
This change adds a missing header include (`<numeric>`) in
`projects/hipcub/test/hipcub/test_hipcub_block_radix_rank.cpp` for the
call it makes to `std::exclusive_scan`.

Co-authored-by: Stanley Tsang <stanley.tsang@amd.com>
@NguyenNhuDi NguyenNhuDi requested review from a team as code owners August 1, 2025 15:29
Copy link
Copy Markdown
Contributor

@umfranzw umfranzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@NguyenNhuDi
Copy link
Copy Markdown
Contributor Author

Closing to reopen on source to trigger all CIs. New PR here: (#1034)

@NguyenNhuDi NguyenNhuDi closed this Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants