Repository navigation
Fix yaml type mismatch in library logic for gfx1201/gfx1250 (13/13 of #6609) - #7421
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (77.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #7421 +/- ##
===========================================
- Coverage 61.83% 61.83% -0.00%
===========================================
Files 2086 2086
Lines 357478 357472 -6
Branches 53910 53910
===========================================
- Hits 221023 221019 -4
+ Misses 117656 117654 -2
Partials 18799 18799
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
talumbau
approved these changes
May 21, 2026
Alex-Vasile
enabled auto-merge (squash)
May 22, 2026 14:21
Alex-Vasile
disabled auto-merge
May 25, 2026 13:41
Alex-Vasile
force-pushed
the
users/alvasil/fix_yaml_13_gfx12xx
branch
from
May 25, 2026 13:42
a2cb78a to
91887d7
Compare
Alex-Vasile
enabled auto-merge (squash)
May 25, 2026 13:43
Part of splitting the original commit 2dbdd7f538b6
("Fix all yaml for type mismatch in tensilelite") into <40-file chunks.
Signed-off-by: pdhirajkumarprasad <dhirajp@amd.com>
Signed-off-by: Alex Vasile <48962821+Alex-Vasile@users.noreply.github.com>
Co-authored-by: pdhirajkumarprasad <dhirajp@amd.com>
Part of splitting the original commit 2dbdd7f538b6
("Fix all yaml for type mismatch in tensilelite") into <40-file chunks.
Signed-off-by: pdhirajkumarprasad <dhirajp@amd.com>
Signed-off-by: Alex Vasile <48962821+Alex-Vasile@users.noreply.github.com>
Co-authored-by: pdhirajkumarprasad <dhirajp@amd.com>
Part of splitting the original commit 2dbdd7f538b6
("Fix all yaml for type mismatch in tensilelite") into <40-file chunks.
Signed-off-by: pdhirajkumarprasad <dhirajp@amd.com>
Signed-off-by: Alex Vasile <48962821+Alex-Vasile@users.noreply.github.com>
Co-authored-by: pdhirajkumarprasad <dhirajp@amd.com>
Alex-Vasile
force-pushed
the
users/alvasil/fix_yaml_13_gfx12xx
branch
from
May 27, 2026 18:33
91887d7 to
5ae6650
Compare
yenong-amd
pushed a commit
that referenced
this pull request
May 28, 2026
…6609) (#7421) ## Motivation We have https://amd-hub.atlassian.net/browse/AIGECORE-2024, where we are giving warning and plan is to upgrade the severity to ERROR. This PR is one of **13 splits of #6609** ("Fix all yaml for type mismatch in tensilelite"), broken up because the original change touched 1,592 files. Each split PR is independent and can be reviewed/merged on its own; together they are equivalent to the original. **This split:** library logic for gfx1201, gfx1250 (1/2 + 2/2) **Files in this PR:** 55 yaml files (3 commits) Original PR: #6609 Original commit on `users/dhirajp/fix_all_warning_in_tensilelite_yaml`: 2dbdd7f538b ## Technical Details For all type mismatch between boolean vs int and vice-versa, we are fixing the yaml with correct type. 6318fdf The contents of every file in this split are byte-identical to that file's version in commit 2dbdd7f538b on the original branch — only the partitioning into commits/PRs changed. ## Test Plan Ran script to find all the yaml file with type mismatch and fix such yaml file. ## Test Result After change, did - build and see no warning - ran complete `hipblaslt-test` and no failure - ran `tox` on `Tensile/common` and no warning/failure The above was validated on the original combined branch (PR #6609); since this split is content-equivalent to a subset of that branch, the same results apply. ## Submission Checklist - [ ] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Signed-off-by: pdhirajkumarprasad <dhirajp@amd.com> Signed-off-by: Alex Vasile <48962821+Alex-Vasile@users.noreply.github.com> Co-authored-by: pdhirajkumarprasad <dhirajp@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We have https://amd-hub.atlassian.net/browse/AIGECORE-2024, where we are giving warning and plan is to upgrade the severity to ERROR.
This PR is one of 13 splits of #6609 ("Fix all yaml for type mismatch in tensilelite"), broken up because the original change touched 1,592 files. Each split PR is independent and can be reviewed/merged on its own; together they are equivalent to the original.
This split: library logic for gfx1201, gfx1250 (1/2 + 2/2)
Files in this PR: 55 yaml files (3 commits)
Original PR: #6609
Original commit on
users/dhirajp/fix_all_warning_in_tensilelite_yaml: 2dbdd7f538bTechnical Details
For all type mismatch between boolean vs int and vice-versa, we are fixing the yaml with correct type.
6318fdf
The contents of every file in this split are byte-identical to that file's version in commit 2dbdd7f538b on the original branch — only the partitioning into commits/PRs changed.
Test Plan
Ran script to find all the yaml file with type mismatch and fix such yaml file.
Test Result
After change, did
hipblaslt-testand no failuretoxonTensile/commonand no warning/failureThe above was validated on the original combined branch (PR #6609); since this split is content-equivalent to a subset of that branch, the same results apply.
Submission Checklist