Repository navigation
[GitHub Actions] Improvements for subtree change detection - #732
Merged
Merged
Conversation
jayhawk-commits
commented
Jul 17, 2025
jayhawk-commits
commented
Collaborator
- Delete logic that removes labels as scenario where a PR decides to change which components get touched is less likely, and conflicts with users manually wanting to assign labels themselves.
- Changed fallback algorithm to use 'gh api' to determine PR base and head SHAs, which allow for replayability in the future in case of intermittent failures. refs will point to branches which may have changed.
- Tested locally with dry-runs of the python script and using large diff PRs (e.g., 598) to verify.
…ction. - Delete logic that removes labels as scenario where a PR decides to change which components get touched is less likely, and conflicts with users manually wanting to assign labels themselves. - Changed fallback algorithm to use 'gh api' to determine PR base and head SHAs, which allow for replayability in the future in case of intermittent failures. refs will point to branches which may have changed. - Tested locally with dry-runs of the python script and using large diff PRs (e.g., 598) to verify.
danielsu-amd
approved these changes
Jul 17, 2025
mpanoop
pushed a commit
to mpanoop/rocm-libraries
that referenced
this pull request
Oct 5, 2026
[ROCm/rocPRIM commit: eb9118a]
mpanoop
pushed a commit
to mpanoop/rocm-libraries
that referenced
this pull request
Oct 5, 2026
[ROCm/rocPRIM commit: eb9118a]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.