[hipblaslt] Fix tensilelite-tests build after MX API signature changes#7277
Open
amd-songpiao wants to merge 1 commit into
Open
[hipblaslt] Fix tensilelite-tests build after MX API signature changes#7277amd-songpiao wants to merge 1 commit into
amd-songpiao wants to merge 1 commit into
Conversation
Two MX test files added in PR ROCm#7017 broke the next day when API renames landed without updating their call sites. CI missed it because tensilelite-tests is gated behind TENSILELITE_BUILD_TESTING=ON (default OFF). - MXDataGen_test.cpp (5 sites): generateMXInput gained a `hipDataType scaleType` 2nd param; pass HIP_R_8F_UE8M0 (UE8M0), matching the canonical mapping in DataInitialization.cpp. - MXScalePadding_test.cpp (2 sites): setMXScaleA/B gained a `rocisa::DataType mxType` 1st param; pass rocisa::DataType::E8, matching tensile_host.cpp's Block_*_UE8M0 cases.
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two MX test files added in PR #7017 broke the next day when API renames landed without updating their call sites. CI missed it because tensilelite-tests is gated behind TENSILELITE_BUILD_TESTING=ON (default OFF).
hipDataType scaleType2nd param; pass HIP_R_8F_UE8M0 (UE8M0), matching the canonical mapping in DataInitialization.cpp.rocisa::DataType mxType1st param; pass rocisa::DataType::E8, matching tensile_host.cpp's Block_*_UE8M0 cases.