Skip to content

[hipDNN]: Initial RFC for Golden Reference Validation #7082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bghimireamd wants to merge 107 commits into
base: develop
Choose a base branch
from
+676 −0
Open

[hipDNN]: Initial RFC for Golden Reference Validation #7082

Changes from all commits
Commits
Show all changes
107 commits
Select commit Hold shift + click to select a range
eebe835
[hipDNN] Add RFC 0010: Golden Reference Validation
bghimireamd May 5, 2026
83f982d
[hipDNN] Refine RFC 0010: improve clarity and reduce redundancy
bghimireamd May 5, 2026
cf37a59
[hipDNN] RFC 0010: clarify benefits, unify step table, fix file links
bghimireamd May 5, 2026
e5b2f80
[hipDNN] RFC 0010: remove rigid step count, rename section
bghimireamd May 5, 2026
29366e9
[hipDNN] RFC 0010: list verification modes in executive summary
bghimireamd May 5, 2026
d6a8831
[hipDNN] RFC 0010: tighten graph fingerprint claims
bghimireamd May 5, 2026
8fd6078
[hipDNN] RFC 0010: add computeSha256 contract note
bghimireamd May 5, 2026
8a2d2ae
[hipDNN] RFC 0010: add tensor name guard to acceptance criteria
bghimireamd May 5, 2026
05570b3
[hipDNN] RFC 0010: explain why duplicate tensor names are rejected
bghimireamd May 5, 2026
ae60d87
[hipDNN] RFC 0010: add acceptance criteria for Step 2
bghimireamd May 5, 2026
c6a89f5
[hipDNN] RFC 0010: address PR review feedback
bghimireamd May 6, 2026
141deda
[hipDNN] RFC 0010: restore Problem Statement as own section
bghimireamd May 6, 2026
50c8d5d
[hipDNN] RFC 0010: fix pipeline table wording and broken link
bghimireamd May 6, 2026
7c1336d
[hipDNN] RFC 0010: add safety guards, known limitations, and FP edge …
bghimireamd May 6, 2026
38b7769
[hipDNN] RFC 0010: remove strides from manifest, redraw diagrams
bghimireamd May 6, 2026
671b05e
[hipDNN] RFC 0010: move determinism requirement into Step 1
bghimireamd May 7, 2026
009d781
[hipDNN] RFC 0010: remove "Who This Serves" section
bghimireamd May 7, 2026
6457fff
[hipDNN] RFC 0010: remove redundant fingerprint paragraph from overview
bghimireamd May 7, 2026
f9da692
[hipDNN] RFC 0010: make fingerprint requirement format-agnostic
bghimireamd May 7, 2026
b17c4b6
[hipDNN] RFC 0010: clarify graph fingerprint fragility and Phase 2 plan
bghimireamd May 7, 2026
c112105
[hipDNN] RFC 0010: document FlatBuffers non-determinism and impact
bghimireamd May 7, 2026
d65debc
[hipDNN] RFC 0010: establish first principle, propose graph-property …
bghimireamd May 7, 2026
f953a89
[hipDNN] RFC 0010: drop redundant sections, rename Layer numbering
bghimireamd May 7, 2026
f41e2da
[hipDNN] RFC 0010: reference existing signature key infrastructure
bghimireamd May 7, 2026
f06263c
[hipDNN] RFC 0010: update diagrams to match renamed checks
bghimireamd May 7, 2026
882f57c
[hipDNN] RFC 0010: redesign data layout and make storage tool-agnostic
bghimireamd May 7, 2026
cfc1d6e
[hipDNN] RFC 0010: use GraphIdentity for directory naming with label …
bghimireamd May 7, 2026
933e38f
remove graph.bin
bghimireamd May 7, 2026
ed56098
[hipDNN] RFC 0010: simplify directory naming to fingerprint hash only
bghimireamd May 7, 2026
d385bc5
[hipDNN] RFC 0010: neutralize tone in JSON vs binary format rationale
bghimireamd May 7, 2026
746a3c9
[hipDNN] RFC 0010: fix seven review issues
bghimireamd May 7, 2026
21b9795
[hipDNN] RFC 0010: move Graph Fingerprint to Step 1, clean up heading…
bghimireamd May 7, 2026
13f52c5
[hipDNN] RFC 0010: fix same-inputs hole in external reference and cro…
bghimireamd May 7, 2026
6bb9160
[hipDNN] RFC 0010: address review comments, pen test fixes, and struc…
bghimireamd May 7, 2026
46144cf
[hipDNN] RFC 0010: tighten wording — fix Zero C++ claim, simplify inf…
bghimireamd May 7, 2026
c945071
[hipDNN] RFC 0010: make generation pipeline source-agnostic
bghimireamd May 7, 2026
17de184
[hipDNN] RFC 0010: pen test fixes — neutralize name, remove dead code…
bghimireamd May 7, 2026
fbba084
[hipDNN] RFC 0010: rename "Graph IS the Key" to "Self-Contained Bundl…
bghimireamd May 7, 2026
d391441
[hipDNN] RFC 0010: clean up Summary per RFC skeleton, trim Future Wor…
bghimireamd May 7, 2026
bcc10ce
[hipDNN] RFC 0010: regenerate pipeline diagrams, align text step counts
bghimireamd May 7, 2026
918f61c
[hipDNN] RFC 0010: clarify golden data format — show full path, expla…
bghimireamd May 7, 2026
61a4008
[hipDNN] RFC 0010: improve wording and add external data validation t…
bghimireamd May 7, 2026
e0e125c
[hipDNN] RFC 0010: thin Design Overview to match team RFC convention
bghimireamd May 7, 2026
32b0cd9
[hipDNN] RFC 0010: move pipeline diagrams to their respective Detaile…
bghimireamd May 8, 2026
200f17d
[hipDNN] RFC 0010: clean up Existing Infrastructure table and reduce …
bghimireamd May 8, 2026
4a78231
[hipDNN] RFC 0010: streamline Generic Test Runner and Generation Pipe…
bghimireamd May 8, 2026
1a020de
[hipDNN] RFC 0010: simplify Reference Sources, align steps with diagrams
bghimireamd May 8, 2026
281048b
[hipDNN] RFC 0010: tighten Design Overview and Verification Modes
bghimireamd May 8, 2026
7d5cd11
[hipDNN] RFC 0010: update Tolerance Framework to reference existing D…
bghimireamd May 8, 2026
ec06ddf
[hipDNN] RFC 0010: streamline Verification Modes through Future Work …
bghimireamd May 8, 2026
9753278
[hipDNN] RFC 0010: document path resolution chain and add consensus g…
bghimireamd May 8, 2026
717c360
[hipDNN] RFC 0010: clarify engine-agnostic bundles, align TestName wi…
bghimireamd May 8, 2026
9b25482
[hipDNN] RFC 0010: drop Harness Integration, tighten Verification Mod…
bghimireamd May 8, 2026
f6dc4de
[hipDNN] RFC 0010: soften PyTorch reference in Generation Pipeline
bghimireamd May 8, 2026
bc72700
[hipDNN] RFC 0010: distinguish proposed from existing in Data Integri…
bghimireamd May 8, 2026
fc7ba69
[hipDNN] RFC 0010: trim storage table, fix Instantiate scope, align r…
bghimireamd May 8, 2026
e9ffef6
[hipDNN] RFC 0010: clarify folder paths and test discovery chain
bghimireamd May 8, 2026
0724f1e
[hipDNN] RFC 0010: clarify Instantiate step with example, simplify wo…
bghimireamd May 8, 2026
7dd648d
[hipDNN] RFC 0010: trim redundant details from Verification Modes, Te…
bghimireamd May 8, 2026
f91f88d
[hipDNN] RFC 0010: remove PyTorch recommendation from Reference Sources
bghimireamd May 8, 2026
a4562e9
[hipDNN] RFC 0010: split test discovery explanation for readability
bghimireamd May 8, 2026
8723926
[hipDNN] RFC 0010: fix schema-change mitigation, add bundle metadata …
bghimireamd May 8, 2026
8aca8a9
[hipDNN] RFC 0010: add reproducible generation to Future Work
bghimireamd May 8, 2026
c066907
[hipDNN] RFC 0010: add graph-only bundles, promote bundle verifier to…
bghimireamd May 8, 2026
f1e45ea
[hipDNN] RFC 0010: clarify graph-only bundle runtime behavior
bghimireamd May 8, 2026
eb9ad78
[hipDNN] RFC 0010: golden tests must respect shared test-filtering me…
bghimireamd May 8, 2026
1a0ce83
[hipDNN] RFC 0010: clarify Small is a file name, not a folder
bghimireamd May 8, 2026
1e77493
[hipDNN] RFC 0010: address all reviewer feedback from adickin-amd
bghimireamd May 10, 2026
c714a65
add more on bundle comparision
bghimireamd May 10, 2026
241deea
[hipDNN] RFC 0010: tier-based folder convention, tolerance deep dive,…
bghimireamd May 10, 2026
6e18d25
Merge branch 'develop' of github.com:ROCm/rocm-libraries into users/b…
bghimireamd May 10, 2026
6c49af5
[hipDNN] RFC 0010: four-part path anatomy, Golden Data Format cleanup…
bghimireamd May 10, 2026
b5c3a8a
[hipDNN] RFC 0010: auto-derive path from graph, auto-tier in Future Work
bghimireamd May 10, 2026
62b3cc4
[hipDNN] RFC 0010: align with existing infrastructure — no auto-disco…
bghimireamd May 10, 2026
f59d2dc
[hipDNN] RFC 0010: bundles are infrastructure-independent
bghimireamd May 10, 2026
b3737d2
[hipDNN] RFC 0010: document binary tensor format for interoperability
bghimireamd May 10, 2026
2f50e70
[hipDNN] RFC 0010: add SHA-256 per-tensor checksum as data integrity …
bghimireamd May 10, 2026
cfdb7c4
[hipDNN] RFC 0010: fold architecture portability into Reference Sourc…
bghimireamd May 10, 2026
2986cfc
[hipDNN] RFC 0010: clarify tolerance priority — TOML overrides persis…
bghimireamd May 10, 2026
7d8df6f
[hipDNN] RFC 0010: restructure Tolerance Framework into three clear s…
bghimireamd May 10, 2026
69fec83
[hipDNN] RFC 0010: rewrite Tolerance Framework — concept-first structure
bghimireamd May 10, 2026
bfc8ed4
[hipDNN] RFC 0010: fully generic test runner — no per-operation C++ code
bghimireamd May 10, 2026
408df77
[hipDNN] RFC 0010: use consistent "offline bundle verifier" terminology
bghimireamd May 10, 2026
a942295
[hipDNN] RFC 0010: address all review comments — align with data-driv…
bghimireamd May 11, 2026
367b820
[hipDNN] RFC 0010: fix component status — "Kept, extended" for modifi…
bghimireamd May 11, 2026
8f414bb
[hipDNN] RFC 0010: rename fixtures, add bundle metadata discussion
bghimireamd May 11, 2026
04211bc
[hipDNN] RFC 0010: three-class design — base + WithRef + WithPlugin
bghimireamd May 11, 2026
6e3088b
[hipDNN] RFC 0010: rename base class to ValidateGoldenBundleBase
bghimireamd May 11, 2026
58e3b38
[hipDNN] RFC 0010: tighten language — remove redundancy and implement…
bghimireamd May 11, 2026
505b45c
[hipDNN] RFC 0010: remove repeated statements — each idea said once
bghimireamd May 11, 2026
f31f809
[hipDNN] RFC 0010: clarify Existing Infrastructure section
bghimireamd May 11, 2026
be6d378
[hipDNN] RFC 0010: tighten component table, remove restated details
bghimireamd May 11, 2026
c68e85c
[hipDNN] RFC 0010: fix broken file links and add new class locations
bghimireamd May 11, 2026
ea91791
[hipDNN] RFC 0010: fix ref executor assumptions and trim detail
bghimireamd May 11, 2026
581bf8b
[hipDNN] RFC 0010: add ValidateGoldenBundleBase row to component table
bghimireamd May 11, 2026
7aa0e2d
[hipDNN] RFC 0010: remove buildGraph() references — bundles are code-…
bghimireamd May 11, 2026
043c4e6
[hipDNN] RFC 0010: trim redundancy, cut implementation detail, add pl…
bghimireamd May 11, 2026
a58785a
[hipDNN] RFC 0010: reorder into substrate-producer-consumer flow
bghimireamd May 12, 2026
8ccac9a
[hipDNN] RFC 0010: address review — rename classes, scope v1, fix int…
bghimireamd May 12, 2026
d80066e
[hipDNN] RFC 0010: add migration plan, collision handling, coverage r…
bghimireamd May 12, 2026
4aef370
remove png file
bghimireamd May 12, 2026
13a0177
Merge branch 'develop' of github.com:ROCm/rocm-libraries into users/b…
bghimireamd May 12, 2026
9555e77
[hipDNN] RFC 0010: remove STUB label, fix grammar typo
bghimireamd May 12, 2026
a61aaad
[hipDNN] RFC 0010: add KnobSettings coverage to Future Work
bghimireamd May 12, 2026
d2d2121
[hipDNN] RFC 0010: address Brian/Aaron/mousdahl review comments
bghimireamd May 14, 2026
34cb620
[hipDNN] RFC 0010: clarify subclass purpose, fill Alternatives rationale
bghimireamd May 14, 2026
448345e
[hipDNN] RFC 0010: resolve open questions, add naming scheme
bghimireamd May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading