[fusilli-provider] Allocate workspace in SDPA integration tests#6712
Merged
Conversation
SdpaIntegrationTest.SdpaIndependentKVHeads (added in #6186) fails at execute time: Workspace of size 8192 bytes required but workspace pointer is null The compiled IREE program for SDPA with independent K/V head counts requires 8 KiB of transient storage, but the test passes nullptr for the workspace pointer. Query the size with `get_workspace_size()` and use the existing `Workspace` RAII helper, matching the pattern in `projects/hipdnn/tests/frontend/IntegrationConvForward.cpp`. Updated tests: - SdpaIntegrationTest.SdpaIndependentKVHeads (was failing) - SdpaIntegrationTest.SimpleSdpa (defensive — currently 0 workspace) - SdpaIntegrationTest.SdpaGqa (defensive — currently 0 workspace) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
AaronStGeorge
approved these changes
Apr 23, 2026
aledudek
pushed a commit
that referenced
this pull request
May 20, 2026
`SdpaIntegrationTest.SdpaIndependentKVHeads` (added in #6186) fails at execute time because the compiled IREE program requires a workspace buffer but the test passes `nullptr`. This adds the required allocation, matching the pattern in `IntegrationConvForward.cpp`. `SdpaIntegrationTest.SimpleSdpa` and `SdpaIntegrationTest.SdpaGqa` don't require a workspace buffer, but are updated the same way for consistency. I ran all SDPA tests locally on gfx942: ``` $ ctest --test-dir fusilli-provider-build -R "Sdpa" Start 22: TestFusilliPluginApi.GetApplicableEngineIdsSdpa 1/4 Test #22: TestFusilliPluginApi.GetApplicableEngineIdsSdpa ... Passed 0.21 sec Start 87: SdpaIntegrationTest.SimpleSdpa 2/4 Test #87: SdpaIntegrationTest.SimpleSdpa .................... Passed 4.33 sec Start 88: SdpaIntegrationTest.SdpaGqa 3/4 Test #88: SdpaIntegrationTest.SdpaGqa ....................... Passed 4.51 sec Start 89: SdpaIntegrationTest.SdpaIndependentKVHeads 4/4 Test #89: SdpaIntegrationTest.SdpaIndependentKVHeads ........ Passed 4.28 sec 100% tests passed, 0 tests failed out of 4 ``` Fixes #6710 Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SdpaIntegrationTest.SdpaIndependentKVHeads(added in #6186) fails at execute time because the compiled IREE program requires a workspace buffer but the test passesnullptr. This adds the required allocation, matching the pattern inIntegrationConvForward.cpp.SdpaIntegrationTest.SimpleSdpaandSdpaIntegrationTest.SdpaGqadon't require a workspace buffer, but are updated the same way for consistency.I ran all SDPA tests locally on gfx942:
Fixes #6710