Repository navigation
[MIOpen]: Get windows build working via the Rock - #6586
Closed
adickin-amd wants to merge 2 commits into
Closed
adickin-amd wants to merge 2 commits into
adickin-amd wants to merge 2 commits into
Conversation
…son natvis workaround - Embed a longPathAware manifest in addkernels.exe so it can traverse the deep build paths used on Windows. - Drop missing .natvis entries from the imported nlohmann_json target when TheRock's prebuilt artifact omits the file. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
JonathanLichtnerAMD
changed the title
Contributor
Author
|
Closing, #7387 does the exact same thing as this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I want to build MIopen on windows using TheRock. This fixes up the few issues I hit while doing this. i have now been successful building miopen using TheRock prebuilt binaries.
Windows fixes: long-path manifest for addkernels, nlohmann_json natvis workaround