CK: Remove duplicate bpreshuffle MX pipeline header (~1,148 lines)#6369
Closed
AviralGoelAMD wants to merge 1 commit into
Closed
Conversation
blockwise_gemm_pipeline_xdlops_v3_mx_bpreshuffle.hpp is a copy-paste duplicate of blockwise_gemm_pipeline_xdlops_b_preshuffle_mx_moe_v3.hpp (1,148 lines each, zero code differences, only class name differs). Update the mx_bpreshuffle_selector to include the canonical file and use its class name (BlockwiseGemmXdlops_pipeline_bpreshuffle_mx_moe_v3). This also fixes a typo in the old class name (bprehuffle -> bpreshuffle). Delete the duplicate. No functional change.
Contributor
Author
|
Closing: deeper analysis revealed the two files have diverged beyond class names. PRs #3098 and #2455 modified the kept file but not the deleted file, introducing real code differences (static_for vs static_ford loop structure, scale offset calculation patterns). Not safe to consolidate without verifying which variant is correct for each kernel path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
blockwise_gemm_pipeline_xdlops_v3_mx_bpreshuffle.hpp, a copy-paste duplicate ofblockwise_gemm_pipeline_xdlops_b_preshuffle_mx_moe_v3.hpp. The files are code-identical (1,148 lines each, only the class name differs). This PR keeps the canonicalb_preshuffle_mx_moe_v3version and updates themx_bpreshuffle_selectorto use it.Changes
blockwise_gemm_pipeline_xdlops_v3_mx_bpreshuffle.hppblockwise_gemm_pipeline_xdlops_mx_bpreshuffle_selector.hppVerification
BlockwiseGemmXdlops_pipeline_v3_mx_bprehuffle)BlockGemmMXBPreshufflePipeline_Selectoroverloads (different template signatures) are included in separate TUs — no ODR riskbprehuffle->bpreshuffle)Cumulative Cleanup Stats
#if 0blocks