hotfix 7.0 use omp config (#565)#624
Merged
Merged
Conversation
find OpenMP config (#517) First search for ROCm's libomp.so via openmp-config.cmake. This is what we would prefer instead of searching for a system libomp.so/libgomp.so and then manually adding in a ROCm lib path. This methodology should still be RHEL-10 RPATH compliant. Co-authored-by: estewart08 <ethan.stewart@amd.com> (cherry picked from commit 408affb)
TorreZuk
requested review from
NaveenElumalaiAMD,
amcamd,
daineAMD,
estewart08 and
rkamd
amcamd
approved these changes
Jul 14, 2025
ammallya
pushed a commit
that referenced
this pull request
Jul 22, 2025
* Add missing C includes [ROCm/hipSPARSE commit: 961cb80]
Contributor
Author
|
@amcamd it says your review is stale, so I presume I can re-request it |
estewart08
approved these changes
Jul 23, 2025
rkamd
approved these changes
Jul 23, 2025
assistant-librarian Bot
pushed a commit
to ROCm/rocBLAS
that referenced
this pull request
Jul 23, 2025
hotfix 7.0 use omp config (#565) find OpenMP config (#517) First search for ROCm's libomp.so via openmp-config.cmake. This is what we would prefer instead of searching for a system libomp.so/libgomp.so and then manually adding in a ROCm lib path. This methodology should still be RHEL-10 RPATH compliant. (cherry picked from commit 408affb61fe3a97d7eecc458f6314da8418035d5)
assistant-librarian Bot
pushed a commit
that referenced
this pull request
Jul 28, 2025
…ny help option is used (#624) * Use only one CLI11 parse and force gtest's help to print as well if any help option is used * Removing more lines omitted in the first commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
find OpenMP config (#517)
First search for ROCm's libomp.so via openmp-config.cmake. This is what we would prefer instead of searching for a system libomp.so/libgomp.so
and then manually adding in a ROCm lib path.
This methodology should still be RHEL-10 RPATH compliant.
(cherry picked from commit 408affb)