Skip to content
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
bd8d3b8
remove opencl dir2d11x11 fwd convlution solver~
iq136boy Apr 3, 2026
ff6b74a
update find-db that referenced the removed solvers
iq136boy Apr 3, 2026
9d1e788
clang format fix
iq136boy Apr 3, 2026
e857b87
add new hip kernel
iq136boy Apr 4, 2026
2166909
add the hip 2d convolution direct solver
iq136boy Apr 4, 2026
727bda9
Merge branch 'develop' into dfeng/remove_conv2dfwdCL
BradPepersAMD Apr 4, 2026
9e79aac
add unit test and update docs
iq136boy Apr 4, 2026
c4123bb
Merge branch 'develop' into dfeng/remove_conv2dfwdCL
iq136boy Apr 6, 2026
e039f8b
Merge branch 'dfeng/fwdconv2d11x11_hip' into dfeng/remove_conv2dfwdCL
iq136boy Apr 6, 2026
4752833
clang format fix
iq136boy Apr 6, 2026
6fd14f6
clang format fix
iq136boy Apr 6, 2026
973e5b3
fix the ci error
iq136boy Apr 6, 2026
ecbe842
change copyright format
iq136boy Apr 6, 2026
9a093e6
define _FLOAT for hip solver
iq136boy Apr 7, 2026
dbf0630
minor fix
iq136boy Apr 7, 2026
a249100
format fix
iq136boy Apr 7, 2026
336661f
change copyright format
iq136boy Apr 7, 2026
e45c004
solve applicable
iq136boy Apr 7, 2026
1e04061
include error fix
iq136boy Apr 8, 2026
9708c8d
solve the unit test bugs
iq136boy Apr 8, 2026
38dcf2c
add new kernel to the cppcheck supression list
iq136boy Apr 8, 2026
804d394
fix the tolerance error
iq136boy Apr 8, 2026
17828ef
address comments
iq136boy Apr 13, 2026
21b5865
Merge branch 'develop' into dfeng/remove_conv2dfwdCL
iq136boy Apr 13, 2026
9b62be0
Merge branch 'develop' into dfeng/remove_conv2dfwdCL
iq136boy Apr 15, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions projects/miopen/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,9 @@ enable_cppcheck(
*:*src/sqlite/*.cpp
*:*.cl
*:*src/kernels/*.h
# MIOpenConvFwd_LxL_11.cpp is a HIP kernel file compiled at runtime with -D defines;
# cppcheck evaluates undefined macros as 0, causing false array-size errors.
*:*src/kernels/MIOpenConvFwd_LxL_11.cpp
knownConditionTrueFalse:*src/kernels/static_composable_kernel/*/*
redundantAssignment:*src/kernels/static_composable_kernel/*/*
unreadVariable:*src/kernels/static_composable_kernel/*/*
Expand Down
2 changes: 1 addition & 1 deletion projects/miopen/docs/how-to/debug-log.rst
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ Some of the solutions have individual controls, which affect both find and immed
* ``MIOPEN_DEBUG_CONV_DIRECT_ASM_7X7C3H224W224`` -- ``ConvAsm7x7c3h224w224k64u2v2p3q3f1``
* ``MIOPEN_DEBUG_CONV_DIRECT_ASM_WRW3X3`` -- ``ConvAsmBwdWrW3x3``
* ``MIOPEN_DEBUG_CONV_DIRECT_ASM_WRW1X1`` -- ``ConvAsmBwdWrW1x1``
* ``MIOPEN_DEBUG_CONV_DIRECT_OCL_FWD11X11`` -- ``ConvOclDirectFwd11x11``
* ``MIOPEN_DEBUG_CONV_DIRECT_HIP_FWD11X11`` -- ``ConvHipDirectFwd11x11``
* ``MIOPEN_DEBUG_CONV_DIRECT_OCL_FWDGEN`` -- ``ConvOclDirectFwdGen``
* ``MIOPEN_DEBUG_CONV_DIRECT_OCL_FWD`` -- ``ConvOclDirectFwd``
* ``MIOPEN_DEBUG_CONV_DIRECT_OCL_FWD1X1`` -- ``ConvOclDirectFwd1x1``
Expand Down
4 changes: 2 additions & 2 deletions projects/miopen/docs/reference/env_variables.rst
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,8 @@ For more information, see :doc:`Logging and debugging <../how-to/debug-log>`.
- | 0: Disable
| 1: Enable

* - | ``MIOPEN_DEBUG_CONV_DIRECT_OCL_FWD11X11``
| Controls ConvOclDirectFwd11x11 direct solution.
* - | ``MIOPEN_DEBUG_CONV_DIRECT_HIP_FWD11X11``
| Controls ConvHipDirectFwd11x11 direct solution.
- | 0: Disable
| 1: Enable

Expand Down
6 changes: 4 additions & 2 deletions projects/miopen/src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,8 @@ set( MIOpen_Source
solver/conv/conv_ocl_dir2D_bwdWrW_1x1.cpp
solver/conv/conv_ocl_dir2D_bwdWrW_2.cpp
solver/conv/conv_ocl_dir2D_bwdWrW_53.cpp
solver/conv/conv_ocl_dir2D11x11.cpp
solver/conv/conv_hip_dir2D11x11.cpp

Comment thread
iq136boy marked this conversation as resolved.
Resolved
solver/conv/conv_ocl_dir2Dfwd.cpp
solver/conv/conv_ocl_dir2Dfwd_exhaustive_search.cpp
solver/conv/conv_ocl_dir2Dfwd1x1.cpp
Expand Down Expand Up @@ -590,7 +591,8 @@ if( MIOPEN_BACKEND MATCHES "OpenCL" OR MIOPEN_BACKEND STREQUAL "HIPOC" OR MIOPEN
kernels/MIOpenConvBwdWrW_LxG_P53.cl
kernels/MIOpenGroupConvBwdWrW_LxG_P53.cl
kernels/MIOpenConvBwdWrW1x1_PAD_read4.cl
kernels/MIOpenConvFwd_LxL_11.cl
kernels/MIOpenConvFwd_LxL_11.cpp

kernels/MIOpenConvFFT.cpp
kernels/MIOpenRNNHiddenStateUpdate.cpp
kernels/bugzilla_34765_detect.s
Expand Down
4 changes: 2 additions & 2 deletions projects/miopen/src/include/miopen/conv/solvers.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -361,11 +361,11 @@ struct MIOPEN_INTERNALS_EXPORT ConvAsm7x7c3h224w224k64u2v2p3q3f1 final : ConvSol
const miopen::conv::ProblemDescription&) const override;
};

struct MIOPEN_INTERNALS_EXPORT ConvOclDirectFwd11x11 final : ConvSolver
struct MIOPEN_INTERNALS_EXPORT ConvHipDirectFwd11x11 final : ConvSolver
{
const std::string& SolverDbId() const override
{
return GetSolverDbId<ConvOclDirectFwd11x11>();
return GetSolverDbId<ConvHipDirectFwd11x11>();
}

bool IsApplicable(const ExecutionContext&,
Expand Down
Loading
Loading