[CK][Windows]: fmha_fwd_head_grouping guard posix headers and use of posix only functions on Windows#5979
Closed
astrelsky wants to merge 1 commit intoROCm:developfrom
Closed
Conversation
This was referenced Mar 29, 2026
Contributor
|
Duplicate of #5977 |
Contributor
Author
Yup I didn't notice it. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The purpose is to fix the build errors when compiling for Windows when
fmha_fwd_head_grouping.hppis included.Technical Details
This checks if
_WIN32is defined and prevents including posix headers and use of posix functions. There is currently no way to get the L3 cache size. If the architecture is not one of the ones currently hardcoded with the L3 cache size, it will return the default error value.Test Plan
Tested locally building flash-attention with CK on Windows. (See comments here Dao-AILab/flash-attention#2400 (comment))
Test Result
Builds successfully only when using setuptools that include the distutils patch here pypa/distutils#406
Submission Checklist
@Snektron @0xDELUXA