Skip to content

[ci] - Adding PR gates for azure #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
geomin12 wants to merge 2 commits into from
Closed

[ci] - Adding PR gates for azure #558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ca42a7
Adding test
geomin12 Jul 8, 2025
5e63308
Adding PR check
geomin12 Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion .azuredevops/hipblaslt.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,20 @@ trigger:
- projects/hipblaslt/.*.y*ml
- projects/hipblaslt/*.md

pr: none
pr:
branches:
include:
- develop
paths:
include:
- projects/hipblaslt
exclude:
- projects/hipblaslt/.githooks
- projects/hipblaslt/.github
Comment on lines +42 to +47

@ScottTodd ScottTodd Jul 9, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with azuredevops to know of any gotchas here. Can you find another reviewer?

At least with github actions, includes/excludes in workflows are not compatible with required checks, and dynamic filtering like what was discussed at #479 is needed (add an anchor job at the end of a workflow that "needs" prior jobs and always runs, then mark that as the required status check).

@geomin12 geomin12 Jul 9, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes i can, I did add that test where it is actually compatible with required checks (#533 , #534 )

Since azure pipelines provides best signal, this will be first! then math-ci + Github checks

- projects/hipblaslt/docs
- projects/hipblaslt/CODEOWNERS
- projects/hipblaslt/.*.y*ml
- projects/hipblaslt/*.md

jobs:
- template: ${{ variables.CI_COMPONENT_PATH }}/hipBLASLt.yml@pipelines_repo
Expand Down
18 changes: 17 additions & 1 deletion .azuredevops/hipcub.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,23 @@ trigger:
- projects/hipcub/LICENSE.txt
- projects/hipcub/NOTICES.txt

pr: none
pr:
branches:
include:
- develop
paths:
include:
- projects/hipcub
exclude:
- projects/hipcub/.githooks
- projects/hipcub/.github
- projects/hipcub/.gitlab
- projects/hipcub/.jenkins
- projects/hipcub/docs
- projects/hipcub/.*.y*ml
- projects/hipcub/*.md
- projects/hipcub/LICENSE.txt
- projects/hipcub/NOTICES.txt

jobs:
- template: ${{ variables.CI_COMPONENT_PATH }}/hipCUB.yml@pipelines_repo
Expand Down
15 changes: 14 additions & 1 deletion .azuredevops/hipfft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,20 @@ trigger:
- projects/hipfft/.*.y*ml
- projects/hipfft/*.md

pr: none
pr:
branches:
include:
- develop
paths:
include:
- projects/hipfft
exclude:
- projects/hipfft/.githooks
- projects/hipfft/.github
- projects/hipfft/.jenkins
- projects/hipfft/docs
- projects/hipfft/.*.y*ml
- projects/hipfft/*.md

jobs:
- template: ${{ variables.CI_COMPONENT_PATH }}/hipFFT.yml@pipelines_repo
Expand Down
16 changes: 15 additions & 1 deletion .azuredevops/hiprand.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,21 @@ trigger:
- projects/hiprand/*.md
- projects/hiprand/LICENSE.txt

pr: none
pr:
branches:
include:
- develop
paths:
include:
- projects/hiprand
exclude:
- projects/hiprand/.githooks
- projects/hiprand/.github
- projects/hiprand/.jenkins
- projects/hiprand/docs
- projects/hiprand/.*.y*ml
- projects/hiprand/*.md
- projects/hiprand/LICENSE.txt

jobs:
- template: ${{ variables.CI_COMPONENT_PATH }}/hipRAND.yml@pipelines_repo
Expand Down
16 changes: 15 additions & 1 deletion .azuredevops/rocblas.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,21 @@ trigger:
- projects/rocblas/*.md
- projects/rocblas/*.rst

pr: none
pr:
branches:
include:
- develop
paths:
include:
- projects/rocblas
exclude:
- projects/rocblas/.githooks
- projects/rocblas/.github
- projects/rocblas/.jenkins
- projects/rocblas/docs
- projects/rocblas/.*.y*ml
- projects/rocblas/*.md
- projects/rocblas/*.rst

jobs:
- template: ${{ variables.CI_COMPONENT_PATH }}/rocBLAS.yml@pipelines_repo
Expand Down
15 changes: 14 additions & 1 deletion .azuredevops/rocfft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,20 @@ trigger:
- projects/rocfft/.*.y*ml
- projects/rocfft/*.md

pr: none
pr:
branches:
include:
- develop
paths:
include:
- projects/rocfft
exclude:
- projects/rocfft/.githooks
- projects/rocfft/.github
- projects/rocfft/.jenkins
- projects/rocfft/docs
- projects/rocfft/.*.y*ml
- projects/rocfft/*.md

jobs:
- template: ${{ variables.CI_COMPONENT_PATH }}/rocFFT.yml@pipelines_repo
Expand Down
18 changes: 17 additions & 1 deletion .azuredevops/rocprim.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,23 @@ trigger:
- projects/rocprim/LICENSE.txt
- projects/rocprim/NOTICES.txt

pr: none
pr:
branches:
include:
- develop
paths:
include:
- projects/rocprim
exclude:
- projects/rocprim/.githooks
- projects/rocprim/.github
- projects/rocprim/.gitlab
- projects/rocprim/.jenkins
- projects/rocprim/docs
- projects/rocprim/.*.y*ml
- projects/rocprim/*.md
- projects/rocprim/LICENSE.txt
- projects/rocprim/NOTICES.txt

jobs:
- template: ${{ variables.CI_COMPONENT_PATH }}/rocPRIM.yml@pipelines_repo
Expand Down
16 changes: 15 additions & 1 deletion .azuredevops/rocrand.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,21 @@ trigger:
- projects/rocrand/*.md
- projects/rocrand/LICENSE.txt

pr: none
pr:
branches:
include:
- develop
paths:
include:
- projects/rocrand
exclude:
- projects/rocrand/.githooks
- projects/rocrand/.github
- projects/rocrand/.jenkins
- projects/rocrand/docs
- projects/rocrand/.*.y*ml
- projects/rocrand/*.md
- projects/rocrand/LICENSE.txt

jobs:
- template: ${{ variables.CI_COMPONENT_PATH }}/rocRAND.yml@pipelines_repo
Expand Down
14 changes: 13 additions & 1 deletion .azuredevops/rocsolver.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,19 @@ trigger:
- projects/rocsolver/.*.y*ml
- projects/rocsolver/*.md

pr: none
pr:
branches:
include:
- develop
paths:
include:
- projects/rocsolver
exclude:
- projects/rocsolver/.github
- projects/rocsolver/.jenkins
- projects/rocsolver/docs
- projects/rocsolver/.*.y*ml
- projects/rocsolver/*.md

jobs:
- template: ${{ variables.CI_COMPONENT_PATH }}/rocSOLVER.yml@pipelines_repo
Expand Down
18 changes: 17 additions & 1 deletion .azuredevops/rocthrust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,23 @@ trigger:
- projects/rocthrust/LICENSE
- projects/rocthrust/NOTICES.txt

pr: none
pr:
branches:
include:
- develop
paths:
include:
- projects/rocthrust
exclude:
- projects/rocthrust/.githooks
- projects/rocthrust/.github
- projects/rocthrust/.jenkins
- projects/rocthrust/doc
- projects/rocthrust/docs
- projects/rocthrust/.*.y*ml
- projects/rocthrust/*.md
- projects/rocthrust/LICENSE
- projects/rocthrust/NOTICES.txt

jobs:
- template: ${{ variables.CI_COMPONENT_PATH }}/rocThrust.yml@pipelines_repo
Expand Down
15 changes: 14 additions & 1 deletion .azuredevops/tensile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,20 @@ trigger:
- shared/tensile/*.md
- shared/tensile/.*.y*ml

pr: none
pr:
branches:
include:
- develop
paths:
include:
- shared/tensile
exclude:
- shared/tensile/.github
- shared/tensile/.jenkins
- shared/tensile/docs
- shared/tensile/tuning_docs
- shared/tensile/*.md
- shared/tensile/.*.y*ml

jobs:
- template: ${{ variables.CI_COMPONENT_PATH }}/Tensile.yml@pipelines_repo
Expand Down