Skip to content

Add missing quote - #5435

Merged
amd-justchen merged 1 commit into
developfrom
users/aalabsi-amd/fix-quote
Mar 13, 2026
Merged

amd-justchen merged 1 commit into
developfrom
users/aalabsi-amd/fix-quote

Conversation

@aalabsi-amd

@aalabsi-amd aalabsi-amd commented Mar 13, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Fix issue where a quote was missed in test_categories.yaml

Technical Details

add it back

Test Plan

None

Test Result

None

Submission Checklist

@aalabsi-amd
aalabsi-amd requested a review from a team as a code owner March 13, 2026 16:28
@aalabsi-amd
aalabsi-amd requested a review from dileepr1 March 13, 2026 16:28

@dileepr1 dileepr1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JonathanLichtnerAMD JonathanLichtnerAMD changed the title Add missing qoute Add missing quote Mar 13, 2026
@aalabsi-amd
aalabsi-amd enabled auto-merge (squash) March 13, 2026 17:08
@amd-justchen

amd-justchen commented Mar 13, 2026 •

Copy link
Copy Markdown
Contributor

Per discussions with @aalabsi-amd and @ScottTodd

Can I get this small PR merged without waiting for CI:
#5435
it's adding a missing quote and it's affecting other PRs.

Such as this one
https://github.com/ROCm/TheRock/actions/runs/23020440135?pr=3769

11.2  -- YAML-based test categorization
11.2  CMake Warning at /__w/TheRock/TheRock/rocm-libraries/shared/ctest/TestCategories.cmake:56 (message):
11.2    Failed to parse test categories YAML: Error: Invalid YAML syntax in
11.2    /__w/TheRock/TheRock/rocm-libraries/projects/miopen/test/gtest/test_categories.yaml:
11.2    while parsing a block collection
11.2  
11.2      in "/__w/TheRock/TheRock/rocm-libraries/projects/miopen/test/gtest/test_categories.yaml", line 311, column 7
11.2  
11.2    expected <block end>, but found '<scalar>'
11.2  
11.2      in "/__w/TheRock/TheRock/rocm-libraries/projects/miopen/test/gtest/test_categories.yaml", line 316, column 10
11.2  
11.2  Call Stack (most recent call first):
11.2    test/gtest/CMakeLists.txt:303 (apply_test_category_labels)
11.2  

Would a yamllint precommit check have caught that? Could revert [ALMIOPEN-990 Re-enable driver tests in targeted categories (#4982) · d8147c3](d8147c3) instead of fixing forward

I wonder why it didn't? it should have failed precommit.
I also think the PR passed because this file wasn't used yet, because there is another Rock PR that was going to use it but it wasn't merged yet.
The PR is now merged: ROCm/TheRock#3595

Keeping that in mind, we'll just fix forward for now and see if it clears up issues. (Will bypass rules and merge)

@amd-justchen
amd-justchen disabled auto-merge March 13, 2026 21:34
@amd-justchen
amd-justchen merged commit bf52984 into develop Mar 13, 2026
24 of 28 checks passed
@amd-justchen
amd-justchen deleted the users/aalabsi-amd/fix-quote branch March 13, 2026 21:36
jovanau pushed a commit to jovanau/rocm-libraries that referenced this pull request Mar 19, 2026
## Motivation

Fix issue where a quote was missed in test_categories.yaml

## Technical Details

add it back

## Test Plan

None
## Test Result

None
## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants