Repository navigation
[hipblaslt] Add custom argument semantic for padding - #5322
Merged
Merged
Conversation
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
AlexBrownAMD
left a comment
AlexBrownAMD
left a comment
Contributor
There was a problem hiding this comment.
I was wondering if the arg definition might be a bit clearer to read if we had an alignment field in the argument, like this:
{ type: address, semantic: AddressD, alignment: 16 }
The kernel arguments structure also has an appendAligned function we could use. We can discuss in the next sync.
AlexBrownAMD
approved these changes
Mar 18, 2026
AlexBrownAMD
left a comment
AlexBrownAMD
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the update!
jinchen62
added a commit
that referenced
this pull request
Mar 25, 2026
- Add padding argument semantic
e.g. { type: uint32, semantic: Padding}
- Add padding param to the arg
e.g. { type: address, semantic: AddressD, padding: 8 }
AIGECORE-1985
jinchen62
added a commit
that referenced
this pull request
Apr 1, 2026
- Add padding argument semantic
e.g. { type: uint32, semantic: Padding}
- Add padding param to the arg
e.g. { type: address, semantic: AddressD, padding: 8 }
AIGECORE-1985
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e.g. { type: uint32, semantic: Padding}
e.g. { type: address, semantic: AddressD, padding: 8 }
AIGECORE-1985