Skip to content

[hipblaslt] Fix fail with kringshift.yaml #5228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nakajee merged 1 commit into from
Mar 9, 2026
Merged

[hipblaslt] Fix fail with kringshift.yaml #5228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 16 additions & 16 deletions projects/hipblaslt/tensilelite/Tensile/KernelWriter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2445,6 +2445,22 @@ def setupNewTile(self, kernel, tensorParametersA, tensorParametersB, isOptNLL=Fa
module.addComment1("global read addresses: shift mxsb")
module.add(self.graShift(kernel, tensorParametersB["MX"]))

# addresses
if not forceNoTileCode:
module.addComment1("global read addresses: addresses a")
module.add(self.graAddresses(kernel, tensorParametersA))
if kernel["ProblemType"]["MXBlockA"]:
module.addComment1("global read addresses: addresses mxsa")
module.add(self.graAddresses(kernel, tensorParametersA["MX"]))
if kernel["ProblemType"]["Sparse"] and not kernel["DirectToVgprSparseMetadata"]:
module.addComment1("global read addresses: addresses metadata")
module.add(self.graAddresses(kernel, tPM))
module.addComment1("global read addresses: addresses b")
module.add(self.graAddresses(kernel, tensorParametersB))
if kernel["ProblemType"]["MXBlockB"]:
module.addComment1("global read addresses: addresses mxsb")
module.add(self.graAddresses(kernel, tensorParametersB["MX"]))

# workgoup SGPRs no longer needed
module.add(self.removeGROffsetsVariableSgprsFromPool(kernel))

Expand All @@ -2468,22 +2484,6 @@ def setupNewTile(self, kernel, tensorParametersA, tensorParametersB, isOptNLL=Fa
self.dontAppendCode = False
self.dontAppendCode = self.dontAppendCode or forceNoTileCode

# addresses
if not forceNoTileCode:
module.addComment1("global read addresses: addresses a")
module.add(self.graAddresses(kernel, tensorParametersA))
if kernel["ProblemType"]["MXBlockA"]:
module.addComment1("global read addresses: addresses mxsa")
module.add(self.graAddresses(kernel, tensorParametersA["MX"]))
if kernel["ProblemType"]["Sparse"] and not kernel["DirectToVgprSparseMetadata"]:
module.addComment1("global read addresses: addresses metadata")
module.add(self.graAddresses(kernel, tPM))
module.addComment1("global read addresses: addresses b")
module.add(self.graAddresses(kernel, tensorParametersB))
if kernel["ProblemType"]["MXBlockB"]:
module.addComment1("global read addresses: addresses mxsb")
module.add(self.graAddresses(kernel, tensorParametersB["MX"]))

# Add increment code
gsuComponent = Component.GSU.find(self)
module.add(gsuComponent.setupNewTile(self, kernel, tensorParametersA, tensorParametersB, tPM))
Expand Down
Loading