Skip to content

Fixed an issue that was caught by Address Sanitizer where memory was being used after being freed. #5220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NolanHannaAMD merged 1 commit into from
Mar 9, 2026
Merged

Fixed an issue that was caught by Address Sanitizer where memory was being used after being freed. #5220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions projects/miopen/src/hipoc/hipoc_program.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,22 +175,22 @@ HIPOCProgramImpl::HIPOCProgramImpl(const fs::path& program_name, const fs::path&
}

HIPOCProgramImpl::HIPOCProgramImpl(const fs::path& program_name, const std::vector<char>& blob)
: program(program_name) ///, module(CreateModuleInMem(blob))
: program(program_name), binary(blob) // Store the binary data to prevent use-after-free
{
const auto& arch = env::value(MIOPEN_DEVICE_ARCH);
if(!arch.empty())
return;
module = CreateModuleInMem(blob);
module = CreateModuleInMem(binary); // Use stored binary instead of parameter
}

HIPOCProgramImpl::HIPOCProgramImpl(const fs::path& program_name,
const std::vector<uint8_t>& blob)
: program(program_name) ///, module(CreateModuleInMem(blob))
HIPOCProgramImpl::HIPOCProgramImpl(const fs::path& program_name, const std::vector<uint8_t>& blob)
: program(program_name),
binary(blob.begin(), blob.end()) // Store the binary data to prevent use-after-free
{
const auto& arch = env::value(MIOPEN_DEVICE_ARCH);
if(!arch.empty())
return;
module = CreateModuleInMem(blob);
module = CreateModuleInMem(binary); // Use stored binary instead of parameter
}

HIPOCProgramImpl::HIPOCProgramImpl(const fs::path& program_name,
Expand Down
Loading