Skip to content

[hipblaslt] Adjust HIPBLASLT_TENSILE_LIBRARY_DIR on Windows. #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stellaraccident merged 3 commits into from
Jul 21, 2025
Merged

[hipblaslt] Adjust HIPBLASLT_TENSILE_LIBRARY_DIR on Windows. #522

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a12e8a
[hipblaslt] Unify HIPBLASLT_TENSILE_LIBRARY_DIR across platforms.
ScottTodd Jul 7, 2025
07315be
Rework library dir for consistency with rocBLAS.
ScottTodd Jul 9, 2025
3bb973c
Merge remote-tracking branch 'upstream/develop' into users/scotttodd/…
ScottTodd Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion projects/hipblaslt/library/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,11 @@ install(

if ( NOT BUILD_CUDA )
if (WIN32)
set( HIPBLASLT_TENSILE_LIBRARY_DIR "\${CPACK_PACKAGING_INSTALL_PREFIX}hipblaslt/bin" CACHE PATH "path to tensile library" )
# Put files used at runtime adjacent to '.dll's and '.exe's in bin/.
set( HIPBLASLT_TENSILE_LIBRARY_DIR "\${CPACK_PACKAGING_INSTALL_PREFIX}${CMAKE_INSTALL_BINDIR}/hipblaslt" CACHE PATH "path to tensile library" )
else()
# Put files used at runtime adjacent to shared libraries ('.so') in
# lib/, separate from executables (no extension) in bin/.
set( HIPBLASLT_TENSILE_LIBRARY_DIR "\${CPACK_PACKAGING_INSTALL_PREFIX}${CMAKE_INSTALL_LIBDIR}/hipblaslt" CACHE PATH "path to tensile library" )
Comment on lines +241 to 246

@TorreZuk TorreZuk Jul 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me if your windows tests pass.

You could fix the string "path to tensile library" to be "path to tensileLite library" (or whatever name should be the standard naming for tensile lite) but that is fine to clarify in separate PR as widespread documentation needs to be changed to avoid confusion. We shouldn't have two different libraries both referred to as tensile.

Would have been nice to have the math-CI windows pipelines running as well as a reference point, as PRs were made by multiple groups but never merged.

@ScottTodd ScottTodd Jul 9, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ellosel (or other hipblaslt developers) any recommendations for names to use or other text to include in these comments?

@ScottTodd ScottTodd Jul 9, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also yes, we'll get all the relevant CI pipelines hooked up so these sorts of changes can be tested by automation.

I'm juggling a bunch of patches but once I land them all I think we'll have CI-produced PyTorch wheels on Windows that can pass sanity checks. I built with all my patches except this one today and got this far:

>>> import torch
>>> batch_matrix1 = torch.ones(10, 2, 3, device="cuda")
>>> batch_matrix2 = torch.ones(10, 3, 4, device="cuda")
>>> result = torch.bmm(batch_matrix1, batch_matrix2)

rocBLAS error: Cannot read D:\projects\TheRock\external-builds\pytorch\.venv\Lib\site-packages\_rocm_sdk_libraries_gfx110X_dgpu\bin\/rocblas/library/TensileLibrary.dat: No such file or directory for GPU arch : gfx1100
 List of available TensileLibrary Files :

rocBLAS error: Could not initialize Tensile host:
directory_iterator::directory_iterator: The system cannot find the path specified.: "D:\projects\TheRock\external-builds\pytorch\.venv\Lib\site-packages\_rocm_sdk_libraries_gfx110X_dgpu\bin\/rocblas/library"

Once the patches are landed and some remaining CI pipelines are wired up we'll have those sorts of PyTorch tests running on ~every commit, for both Linux and Windows.

endif()
# For ASAN package, Tensile library files are not required
Expand Down
5 changes: 4 additions & 1 deletion projects/hipblaslt/next-cmake/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,8 +351,11 @@ endif()

if(HIPBLASLT_ENABLE_DEVICE)
if(WIN32)
set(HIPBLASLT_TENSILE_LIBRARY_DIR "\${CPACK_PACKAGING_INSTALL_PREFIX}hipblaslt/bin" CACHE PATH "path to tensile library")
# Put files used at runtime adjacent to '.dll's and '.exe's in bin/.
set(HIPBLASLT_TENSILE_LIBRARY_DIR "\${CPACK_PACKAGING_INSTALL_PREFIX}${CMAKE_INSTALL_BINDIR}/hipblaslt" CACHE PATH "path to tensile library")
else()
# Put files used at runtime adjacent to shared libraries ('.so') in
# lib/, separate from executables (no extension) in bin/.
set(HIPBLASLT_TENSILE_LIBRARY_DIR "\${CPACK_PACKAGING_INSTALL_PREFIX}${CMAKE_INSTALL_LIBDIR}/hipblaslt" CACHE PATH "path to tensile library")
endif()
rocm_install(
Expand Down