Skip to content

[hipBLASLt] Fix numeric regression of MXFP4 #4808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
amd-chunxlin wants to merge 3 commits into from
Closed

[hipBLASLt] Fix numeric regression of MXFP4 #4808

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ea997b
Workaround for solving the numeric issue
amd-chunxlin Feb 23, 2026
6491301
Fix appending the wrong scale pointers
amd-chunxlin Feb 23, 2026
0bbf5f7
Remove comment
amd-chunxlin Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions projects/hipblaslt/tensilelite/src/ContractionSolution.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,10 +807,7 @@ namespace TensileLite
autoWGMXCCCHUNK,
autoGsuVal);

// NOTE: an assumption here is A & B must be both MX data types or non-MX data types.
// Mixing is not supported.
if(!problemType.useScaleAB.empty() or
(problemType.mxBlockA != 0 && problemType.mxBlockB != 0)) //kernel input data
if(!problemType.useScaleAB.empty())
{
args.template append<void const*>("scaleA", inputs.scaleA);
args.template append<void const*>("scaleB", inputs.scaleB);
Expand Down
Loading