[hipblaslt-provider] Convert hipblaslt-provider to stream-style logging#4440
Merged
BrianHarrisonAMD merged 1 commit intoFeb 10, 2026
Conversation
Remove spdlog/fmt dependency from hipblaslt-provider by converting all
format-string style logging to stream-style:
- HIPDNN_PLUGIN_LOG_*("msg: {}", val) → HIPDNN_PLUGIN_LOG_*("msg: " << val)
- LOG_API_*("msg={}", val) → LOG_API_*("msg=" << val)
Also removes:
- hipdnn_enable_spdlog() calls from CMakeLists.txt files
- spdlog includes and shutdown calls from test main.cpp files
This change is part of removing spdlog/fmt from plugin_sdk, enabling
providers to work without these dependencies.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
a-sidorova
approved these changes
Feb 10, 2026
Contributor
a-sidorova
left a comment
a-sidorova
left a comment
There was a problem hiding this comment.
@BrianHarrisonAMD thank you for the changes!
BrianHarrisonAMD
merged commit f8b9420
into
users/bharriso/logging-changes-cleanup
8 checks passed
BrianHarrisonAMD
deleted the
users/bharriso/hipblaslt-provider-stream-logging
branch
BrianHarrisonAMD
added a commit
that referenced
this pull request
Feb 13, 2026
## Motivation With the removal of spdlog & fmt from the data_sdk (#4312) we moved this capability to the plugin SDK to minimize changes. #4442 & #4440 swapped existing providers to stream style logging, and the Fusilli plugin has decided to do the same. Now that no provider will depend on spdlog / fmt from plugin_sdk we are removing this option. Plugin authors can decide on their preferred logging style / macros, but the provided ones from the hipDNN SDK will be unified. ## Technical Details - Remove existing spdlog / fmt options from plugin_sdk. ## Test Plan Build and tests pass. ## Test Result Build and tests passing locally (waiting on CI). --- ### Note this is branched off the logging cleanup branch! --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
SamuelReeder
pushed a commit
that referenced
this pull request
Feb 17, 2026
## Motivation With the removal of spdlog & fmt from the data_sdk (#4312) we moved this capability to the plugin SDK to minimize changes. #4442 & #4440 swapped existing providers to stream style logging, and the Fusilli plugin has decided to do the same. Now that no provider will depend on spdlog / fmt from plugin_sdk we are removing this option. Plugin authors can decide on their preferred logging style / macros, but the provided ones from the hipDNN SDK will be unified. ## Technical Details - Remove existing spdlog / fmt options from plugin_sdk. ## Test Plan Build and tests pass. ## Test Result Build and tests passing locally (waiting on CI). --- ### Note this is branched off the logging cleanup branch! --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
kamuruga08
pushed a commit
that referenced
this pull request
Feb 19, 2026
## Motivation With the removal of spdlog & fmt from the data_sdk (#4312) we moved this capability to the plugin SDK to minimize changes. #4442 & #4440 swapped existing providers to stream style logging, and the Fusilli plugin has decided to do the same. Now that no provider will depend on spdlog / fmt from plugin_sdk we are removing this option. Plugin authors can decide on their preferred logging style / macros, but the provided ones from the hipDNN SDK will be unified. ## Technical Details - Remove existing spdlog / fmt options from plugin_sdk. ## Test Plan Build and tests pass. ## Test Result Build and tests passing locally (waiting on CI). --- ### Note this is branched off the logging cleanup branch! --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
kamuruga08
pushed a commit
that referenced
this pull request
Feb 19, 2026
## Motivation With the removal of spdlog & fmt from the data_sdk (#4312) we moved this capability to the plugin SDK to minimize changes. #4442 & #4440 swapped existing providers to stream style logging, and the Fusilli plugin has decided to do the same. Now that no provider will depend on spdlog / fmt from plugin_sdk we are removing this option. Plugin authors can decide on their preferred logging style / macros, but the provided ones from the hipDNN SDK will be unified. ## Technical Details - Remove existing spdlog / fmt options from plugin_sdk. ## Test Plan Build and tests pass. ## Test Result Build and tests passing locally (waiting on CI). --- ### Note this is branched off the logging cleanup branch! --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Remove spdlog/fmt dependency from hipblaslt-provider.
This change is part of removing spdlog/fmt from plugin_sdk.
Technical Details
Changes:
Test Plan
Build and tests are working locally (CI not enabled for hipblaslt-provider yet).
Logs are properly output (unchanged).
Test Result
Build and tests are continuing to pass.
Logs are printing properly.
Note
Off the logging clean-up branch (PR #4423) that is about to be merged.
This ensures we have the latest namespaces, and other clean-up changes for this work.