[hipDNN] Consolidate backend logger into a single instance.#4428
Merged
Conversation
…nction and clean-up affected code.
Comment on lines
+40
to
49
| #define HIPDNN_BACKEND_LOG_ERROR(...) \ | ||
| do \ | ||
| { \ | ||
| hipdnn_backend::logging::initialize(); \ | ||
| if(hipdnn_data_sdk::logging::isLogLevelEnabled(HIPDNN_SEV_ERROR)) \ | ||
| { \ | ||
| hipdnn_backend::logging::logMessage( \ | ||
| HIPDNN_SEV_ERROR, fmt::format("[hipdnn_backend] {}", fmt::format(__VA_ARGS__))); \ | ||
| } \ | ||
| } while(0) |
Contributor
There was a problem hiding this comment.
Oh interesting, I guess this is how you handle the double formatting hehe.
Contributor
Author
There was a problem hiding this comment.
[2026-02-09 19:35:28.114] [tid 232181] [info] System Information: {System Name: Linux, Node Name: bb88fa0967dd, Release: 5.15.0-112-generic, Version: #122-Ubuntu SMP Thu May 23 07:48:21 UTC 2024, Machine: x86_64}
[2026-02-09 19:35:28.234] [tid 232181] [info] HIP Device Information: {Device: 0, Name: AMD Instinct MI210, Global Mem: 68702699520 bytes, Compute: 9.0, MPs: 104, Clock: 1700000 kHz}
[2026-02-09 19:35:28.234] [tid 232181] [info] [hipdnn_backend] API called: [hipdnnCreate] handle_ptr=0x7ffd79576e40
[2026-02-09 19:35:28.234] [tid 232181] [info] [hipdnn_backend] Attempting to load plugin from [/develop/work/rocmlibs2/projects/hipdnn/build/debug/installdir/lib/hipdnn_plugins/engines/libmiopen_legacy_plugin.so]
[2026-02-09 19:35:28.234] [tid 232181] [info] [hipdnn_backend] SharedLibrary: Attempting to load shared library from final absolute path: /develop/work/rocmlibs2/projects/hipdnn/build/debug/installdir/lib/hipdnn_plugins/engines/libmiopen_legacy_plugin.so
[2026-02-09 19:35:30.631] [tid 232181] [info] [hipdnn_backend] Plugin loaded successfully: /develop/work/rocmlibs2/projects/hipdnn/build/debug/installdir/lib/hipdnn_plugins/engines/libmiopen_legacy_plugin.so
[2026-02-09 19:35:30.631] [tid 232216] [info] [miopen_plugin] API success: [hipdnnPluginSetLoggingCallbackImpl]
[2026-02-09 19:35:30.631] [tid 232181] [info] [hipdnn_backend] Plugin info: name=miopen_plugin, version=1.0.0, type=HIPDNN_PLUGIN_TYPE_ENGINE(1)
[2026-02-09 19:35:30.631] [tid 232216] [info] [miopen_plugin] API called: [hipdnnEnginePluginGetAllEngineIdsImpl] engineIds=0x0, maxEngines=0, numEngines=0x7ffd79575e84
[2026-02-09 19:35:30.631] [tid 232216] [info] [miopen_plugin] API success: [hipdnnEnginePluginGetAllEngineIdsImpl] numEngines=1 totalEngines=1
[2026-02-09 19:35:30.631] [tid 232216] [info] [miopen_plugin] API called: [hipdnnEnginePluginGetAllEngineIdsImpl] engineIds=0x563a322412f0, maxEngines=1, numEngines=0x7ffd79575e84
[2026-02-09 19:35:30.631] [tid 232216] [info] [miopen_plugin] API success: [hipdnnEnginePluginGetAllEngineIdsImpl] numEngines=1 totalEngines=1
[2026-02-09 19:35:30.631] [tid 232181] [info] [hipdnn_backend] Attempting to load plugin from [/develop/work/rocmlibs2/projects/hipdnn/build/debug/installdir/lib/hipdnn_plugins/engines/libmiopen_plugin.so]
[2026-02-09 19:35:30.631] [tid 232181] [info] [hipdnn_backend] SharedLibrary: Attempting to load shared library from final absolute path: /develop/work/rocmlibs2/projects/hipdnn/build/debug/installdir/lib/hipdnn_plugins/engines/libmiopen_plugin.so
[2026-02-09 19:35:30.633] [tid 232217] [info] [miopen_plugin] API success: [hipdnnPluginSetLoggingCallbackImpl]
[2026-02-09 19:35:30.634] [tid 232217] [info] [miopen_plugin] API called: [hipdnnEnginePluginGetAllEngineIdsImpl] engineIds=0x0, maxEngines=0, numEngines=0x7ffd79575e84
[2026-02-09 19:35:30.634] [tid 232217] [info] [miopen_plugin] API success: [hipdnnEnginePluginGetAllEngineIdsImpl] numEngines=1 totalEngines=1
[2026-02-09 19:35:30.634] [tid 232217] [info] [miopen_plugin] API called: [hipdnnEnginePluginGetAllEngineIdsImpl] engineIds=0x563a2e1a46c0, maxEngines=1, numEngines=0x7ffd79575e84
[2026-02-09 19:35:30.634] [tid 232217] [info] [miopen_plugin] API success: [hipdnnEnginePluginGetAllEngineIdsImpl] numEngines=1 totalEngines=1
[2026-02-09 19:35:30.634] [tid 232181] [error] [hipdnn_backend] Error occured in status:HIPDNN_STATUS_UNKNOWN message:Error loading plugin from [/develop/work/rocmlibs2/projects/hipdnn/build/debug/installdir/lib/hipdnn_plugins/engines/libmiopen_plugin.so]: Engine ID 1563989756945604898 already exists in the list
[2026-02-09 19:35:30.634] [tid 232216] [info] [miopen_plugin] API called: [hipdnnEnginePluginCreateImpl] handle_ptr=0x7ffd795762e0
[2026-02-09 19:35:30.678] [tid 232216] [info] [miopen_plugin] Creating MiopenContainer
[2026-02-09 19:35:30.678] [tid 232216] [info] [miopen_plugin] API success: [hipdnnEnginePluginCreateImpl] createdHandle=0x563a3222ba30
[2026-02-09 19:35:30.678] [tid 232181] [info] [hipdnn_backend] Created handle: 0x563a00776ee0
[2026-02-09 19:35:30.678] [tid 232181] [info] [hipdnn_backend] API success: [hipdnnCreate] createHandle=hipdnnHandle: {stream=null, EnginePluginResourceManager: {loadedPlugins=1, loadedPluginPaths=[/develop/work/rocmlibs2/projects/hipdnn/build/debug/installdir/lib/hipdnn_plugins/engines/libmiopen_legacy_plugin.so]}}
Running convolution fprop graph fp32 [NCHW]...
[2026-02-09 19:35:30.678] [tid 232181] [info] [hipdnn_frontend] Creating new Graph instance
BrianHarrisonAMD
approved these changes
Feb 9, 2026
Contributor
BrianHarrisonAMD
left a comment
BrianHarrisonAMD
left a comment
There was a problem hiding this comment.
LGTM assuming tests are passing, and we did a sanity check that the logs look correct.
CMiservaAMD
deleted the
users/cmiserva/almiopen-1028/consolidate-single-backend-logger
branch
CMiservaAMD
added a commit
that referenced
this pull request
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist