Skip to content

Add hipCUB CCCL 3.0.x support#4079

Open
matyas-streamhpc wants to merge 95 commits into
ROCm:developfrom
StreamHPC:users/matyas-streamhpc/hipcub-cccl-3-0
Open

Add hipCUB CCCL 3.0.x support#4079
matyas-streamhpc wants to merge 95 commits into
ROCm:developfrom
StreamHPC:users/matyas-streamhpc/hipcub-cccl-3-0

Conversation

@matyas-streamhpc
Copy link
Copy Markdown
Contributor

@matyas-streamhpc matyas-streamhpc commented Jan 26, 2026

Add CCCL 3.0.x support for hipCUB library.

Additional updates: fix CUB backend

@assistant-librarian assistant-librarian Bot added the external contribution Code contribution from users community.. label Jan 26, 2026
@matyas-streamhpc matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from b533ef0 to f0e93d0 Compare January 27, 2026 17:34
@RobsonRLemos RobsonRLemos added the organization: streamhpc contributors from streamhpc label Jan 28, 2026
@matyas-streamhpc matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from f0e93d0 to 425029f Compare January 29, 2026 10:36
@matyas-streamhpc matyas-streamhpc marked this pull request as ready for review January 29, 2026 10:50
@matyas-streamhpc matyas-streamhpc requested review from a team as code owners January 29, 2026 10:50
@matyas-streamhpc matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from 425029f to 45bf6cd Compare January 29, 2026 14:21
Comment thread projects/hipcub/hipcub/include/hipcub/backend/cub/device/device_reduce.hpp Outdated
Comment thread projects/hipcub/hipcub/include/hipcub/backend/cub/device/device_select.hpp Outdated
@matyas-streamhpc matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from 64c2f95 to a6bd6e0 Compare February 9, 2026 10:58
Comment thread projects/rocprim/CHANGELOG.md Outdated
@matyas-streamhpc matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from a6bd6e0 to 01c6c4a Compare February 11, 2026 19:37
@stanleytsang-amd
Copy link
Copy Markdown
Contributor

There are merge conflicts and it looks like the RadixSort 4g test is still failing as well as DeviceMerge. Rerunning CI to make sure it isn't a flaky CI problem, but perhaps the RadixSort test fix is not quite there yet.

@stanleytsang-amd
Copy link
Copy Markdown
Contributor

@matyas-streamhpc RadixSort 4G test is timing out on Windows + gfx1151

47/47 Test #23: hipcub.DeviceRadixSort ............***Timeout 305.22 sec
Running main() from B:\build\third-party\googletest\source\googletest\src\gtest_main.cc
[==========] Running 126 tests from 32 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from HipcubDeviceRadixSort
[ RUN ] HipcubDeviceRadixSort.SortKeysOver4G

Also please resolve the merge conflicts, I am unable to run math-ci until then.

@matyas-streamhpc matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from 01c6c4a to 5129a04 Compare March 5, 2026 08:50
@matyas-streamhpc
Copy link
Copy Markdown
Contributor Author

@matyas-streamhpc RadixSort 4G test is timing out on Windows + gfx1151

47/47 Test #23: hipcub.DeviceRadixSort ............***Timeout 305.22 sec Running main() from B:\build\third-party\googletest\source\googletest\src\gtest_main.cc [==========] Running 126 tests from 32 test suites. [----------] Global test environment set-up. [----------] 2 tests from HipcubDeviceRadixSort [ RUN ] HipcubDeviceRadixSort.SortKeysOver4G

Also please resolve the merge conflicts, I am unable to run math-ci until then.

I rebased the branch and I added the fix for Windows. The CI job is passing for Windows now.

@matyas-streamhpc matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch 3 times, most recently from e012a58 to c38a3c2 Compare March 16, 2026 13:04
@matyas-streamhpc matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from b146369 to 89a22db Compare March 18, 2026 13:51
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4079       +/-   ##
============================================
- Coverage    67.26%   39.04%   -28.22%     
============================================
  Files         1844      152     -1692     
  Lines       284014    25692   -258322     
  Branches     39839      567    -39272     
============================================
- Hits        191037    10031   -181006     
+ Misses       76518    15284    -61234     
+ Partials     16459      377    -16082     
Flag Coverage Δ
hipBLAS ?
hipBLASLt ?
hipCUB ?
hipDNN ?
hipFFT ?
hipRAND ?
hipSOLVER ?
hipSPARSE ?
rocBLAS ?
rocFFT ?
rocPRIM 39.04% <ø> (?)
rocRAND ?
rocSOLVER ?
rocSPARSE ?
Files with missing lines Coverage Δ
...ts/rocprim/rocprim/include/rocprim/type_traits.hpp 65.27% <ø> (ø)

... and 1992 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matyas-streamhpc matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from 89a22db to 6019c3c Compare March 23, 2026 11:49
@matyas-streamhpc matyas-streamhpc force-pushed the users/matyas-streamhpc/hipcub-cccl-3-0 branch from 6019c3c to 555b351 Compare April 20, 2026 15:05
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

  • Add new commits
  • Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

@github-actions github-actions Bot added the Stale PR has no activity for 25+ days label May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants