Skip to content

[TheRock CI] - Run the therock-ci continuously on pushes so we have ongoing signal pt 2#389

Merged
geomin12 merged 4 commits into
developfrom
users/geomin12/adding-continous-ci
Jun 25, 2025
Merged

[TheRock CI] - Run the therock-ci continuously on pushes so we have ongoing signal pt 2#389
geomin12 merged 4 commits into
developfrom
users/geomin12/adding-continous-ci

Conversation

@geomin12
Copy link
Copy Markdown
Collaborator

Had to revert and fix for a checkout issue

Adding continuous CI to provide signal so that the team can garden appropriately.

Currently, TheRock CI only supports pull request checks. In order to get more signals, we are adding TheRock CI capability for:

push to develop (runs all projects)
workflow dispatch (runs some to all projects)

@geomin12
Copy link
Copy Markdown
Collaborator Author

geomin12 commented Jun 25, 2025

@ScottTodd sorry for the whirlwind of PRs, looks like this works (and also doesn't require the ref as well, it defaults to refs/remotes/pull/389/merge)

Copy link
Copy Markdown
Contributor

@amd-chrissosa amd-chrissosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this is a lot cleaner.

Copy link
Copy Markdown
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Trusting that this will work this time. I think https://github.com/ROCm/rocm-libraries/actions/runs/15888008207/job/44804592791?pr=389 should run tests when therock-ci.yml or therock-ci-linux.yml (and any related files) are changed. It would be easier to review this if I saw it running on the PR itself, though the differences in pull_request vs push triggering would still make that a bit tricky.

@geomin12
Copy link
Copy Markdown
Collaborator Author

Thanks!

Trusting that this will work this time. I think https://github.com/ROCm/rocm-libraries/actions/runs/15888008207/job/44804592791?pr=389 should run tests when therock-ci.yml or therock-ci-linux.yml (and any related files) are changed. It would be easier to review this if I saw it running on the PR itself, though the differences in pull_request vs push triggering would still make that a bit tricky.

Yeah, it's a bit tricky with push / workflow_dispatch. However, after this gets landed, we can use workflow_dispatch going forward to test!

@geomin12 geomin12 merged commit d9b3428 into develop Jun 25, 2025
3 checks passed
@geomin12 geomin12 deleted the users/geomin12/adding-continous-ci branch June 25, 2025 22:14
geomin12 added a commit that referenced this pull request Jul 7, 2025
…ngoing signal pt 2 (#389)

Had to revert and fix for a checkout issue

Adding continuous CI to provide signal so that the team can garden
appropriately.

Currently, TheRock CI only supports pull request checks. In order to get
more signals, we are adding TheRock CI capability for:

push to develop (runs all projects)
workflow dispatch (runs some to all projects)
bethune-bryant pushed a commit to bethune-bryant/rocm-libraries that referenced this pull request Jul 11, 2025
… documentation refresh (ROCm#378) (ROCm#389)

First phase of hipSOLVER documentation refresh (ROCm#378)

* First phase of hipSOLVER docs refresh

* Update meta data

* Standardize capitalization

* Incorporate feedback from review

(cherry picked from commit 87fb874)
ammallya pushed a commit that referenced this pull request Nov 5, 2025
…tensorGetVersion` redefinition (#407)

- Upgrades the C++ standard from C++17 to C++20 (resolves [Feature]: Upgrade to c++20 #405)
- Exports the C API headers (resolves [Feature]: C api headers like cuTENSOR #389)
- Fix a compilation error related to the redefinition of the hiptensorGetVersion function
ammallya pushed a commit that referenced this pull request Nov 5, 2025
…tensorGetVersion` redefinition (#407)

- Upgrades the C++ standard from C++17 to C++20 (resolves [Feature]: Upgrade to c++20 #405)
- Exports the C API headers (resolves [Feature]: C api headers like cuTENSOR #389)
- Fix a compilation error related to the redefinition of the hiptensorGetVersion function

[ROCm/hipTensor commit: cbba13a]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants