[TheRock CI] - Run the therock-ci continuously on pushes so we have ongoing signal pt 2#389
Conversation
|
@ScottTodd sorry for the whirlwind of PRs, looks like this works (and also doesn't require the |
amd-chrissosa
left a comment
There was a problem hiding this comment.
Thanks this is a lot cleaner.
ScottTodd
left a comment
There was a problem hiding this comment.
Thanks!
Trusting that this will work this time. I think https://github.com/ROCm/rocm-libraries/actions/runs/15888008207/job/44804592791?pr=389 should run tests when therock-ci.yml or therock-ci-linux.yml (and any related files) are changed. It would be easier to review this if I saw it running on the PR itself, though the differences in pull_request vs push triggering would still make that a bit tricky.
Yeah, it's a bit tricky with push / workflow_dispatch. However, after this gets landed, we can use |
…ngoing signal pt 2 (#389) Had to revert and fix for a checkout issue Adding continuous CI to provide signal so that the team can garden appropriately. Currently, TheRock CI only supports pull request checks. In order to get more signals, we are adding TheRock CI capability for: push to develop (runs all projects) workflow dispatch (runs some to all projects)
…tensorGetVersion` redefinition (#407) - Upgrades the C++ standard from C++17 to C++20 (resolves [Feature]: Upgrade to c++20 #405) - Exports the C API headers (resolves [Feature]: C api headers like cuTENSOR #389) - Fix a compilation error related to the redefinition of the hiptensorGetVersion function
…tensorGetVersion` redefinition (#407) - Upgrades the C++ standard from C++17 to C++20 (resolves [Feature]: Upgrade to c++20 #405) - Exports the C API headers (resolves [Feature]: C api headers like cuTENSOR #389) - Fix a compilation error related to the redefinition of the hiptensorGetVersion function [ROCm/hipTensor commit: cbba13a]
Had to revert and fix for a checkout issue
Adding continuous CI to provide signal so that the team can garden appropriately.
Currently, TheRock CI only supports pull request checks. In order to get more signals, we are adding TheRock CI capability for:
push to develop (runs all projects)
workflow dispatch (runs some to all projects)