Skip to content

Test Filter Standardization Proof of Concept - MIOpen #3513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dileepr1 merged 26 commits into from
Feb 24, 2026
Merged

Test Filter Standardization Proof of Concept - MIOpen #3513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
4d5ba8a
Adding miopen POC for Test Filter Standardization
Dec 22, 2025
ad8deb2
Adding pre-commit changes
Dec 22, 2025
6e9ea9e
add functionality for gpu specific exclusions
Jan 14, 2026
a3a09c0
Adding pre-commit changes
Jan 14, 2026
b085a2a
Add better logic for gpu based exclusion. Todo: cleanup parse_test_ca…
Jan 16, 2026
18acc5a
Add the required gpu exclusions and use yaml anchors to improve reada…
Jan 19, 2026
a954620
Add documentation for gpu_excludes.
Jan 20, 2026
7349554
Add patterns to categories and improve readability
Jan 21, 2026
3484c5e
Add an install time CTesttestfile with relative path to miopen_gtest …
Jan 26, 2026
785e409
Clean up the labels and add filters as per TheRock Commit 200d502 (AL…
Jan 27, 2026
5a3d875
correct test_categories, and use exclusions as negative filters rathe…
Jan 31, 2026
4801d06
Add gtest filters as {positive_filters}-{negative_filters} rather tha…
Jan 31, 2026
63d6152
Add a timeout multiplier, and update the documentation
Feb 2, 2026
60d161e
Remove the quotes around gtest pattern to mimic existing behavior
Feb 2, 2026
79d6711
Increase timeout to help MIOpen tests run to completion
Feb 4, 2026
266c3ab
Add exclude pattern for rocm-1016.
Feb 5, 2026
3ebf03e
Changes in parser to improve clarity and readability
Feb 5, 2026
f3e090c
Exclude slower tests as per #3362
Feb 11, 2026
d136d7e
Remove debugs and add empty string check
Feb 17, 2026
bb60a74
Add error handling in TestCategories.cmake
Feb 17, 2026
dc0fa5a
Using context managers (with statement) for file operations
Feb 17, 2026
7ee05a5
Add input validation in TestCategories.cmake
Feb 18, 2026
fc83ef9
Made exceptions verbose.
Feb 18, 2026
02ec0ee
Exclude tests added as part of Test Filter Standardization from 'make…
Feb 20, 2026
5cf141a
Add optional enhanced metadata fields to test categories (#4109)
tony-davis Feb 20, 2026
31bdb07
Remove the $ to help ninja build
Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions projects/miopen/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
################################################################################
cmake_minimum_required( VERSION 3.15 )

#Add a name for the rocm-libraries location
set(ROCM_LIBRARIES_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/../../")

if (POLICY CMP0074)
cmake_policy(SET CMP0074 NEW)
endif()
Expand Down
3 changes: 2 additions & 1 deletion projects/miopen/test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,8 @@ else()
add_definitions(-DMIOPEN_TEST_DRIVER_MODE=1)
endif()

add_custom_target(check COMMAND ${CMAKE_CTEST_COMMAND} --output-on-failure --verbose -C ${CMAKE_CFG_INTDIR})
# Exclude *-suite tests added as part of test filter standardization(#3513) from check target to avoid running them during build.
add_custom_target(check COMMAND ${CMAKE_CTEST_COMMAND} --output-on-failure --verbose -C ${CMAKE_CFG_INTDIR} --exclude-regex ".*-suite")
add_custom_target(tests)

if(MIOPEN_TEST_GPU_DETECTION_FAILED AND NOT (MIOPEN_NO_GPU))
Expand Down
31 changes: 30 additions & 1 deletion projects/miopen/test/gtest/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ endforeach()
# Otherwise, all files in ${SOURCES} are rebuilt for each test.
add_library(miopen_gtest_common STATIC ${SOURCES})
target_include_directories(miopen_gtest_common PRIVATE ../ ../../src/kernels)
target_link_libraries(miopen_gtest_common PRIVATE GTest::gtest MIOpen)
target_link_libraries(miopen_gtest_common PRIVATE GTest::gtest GTest::gmock MIOpen)
Comment thread
aalabsi-amd marked this conversation as resolved.
Resolved
if(WIN32)
# Refer to https://en.cppreference.com/w/cpp/language/types for details.
target_compile_options(miopen_gtest_common PRIVATE $<BUILD_INTERFACE:$<$<CXX_COMPILER_ID:Clang>:-U__LP64__>>)
Expand Down Expand Up @@ -280,3 +280,32 @@ endif()

message(STATUS "gtest env: MIOPEN_USER_DB_PATH=${CMAKE_CURRENT_BINARY_DIR}")
message(STATUS "gtest env: MIOPEN_TEST_COMPOSABLEKERNEL=${MIOPEN_TEST_COMPOSABLEKERNEL}")

# Create install-time test file for distribution
set(INSTALL_TEST_FILE "${CMAKE_CURRENT_BINARY_DIR}/install_CTestTestfile.cmake")
file(WRITE "${INSTALL_TEST_FILE}"
[=[
# This is a test file generated by MIOpen for install time.
# Tests are defined with relative paths to work in the installed location.
]=]
)

#Enable the test categories in test_categories.yaml
include(${ROCM_LIBRARIES_ROOT}/shared/ctest/TestCategories.cmake)
Comment thread
dileepr1 marked this conversation as resolved.
Resolved
if (EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/test_categories.yaml")
message(STATUS "YAML-based test categorization")
apply_test_category_labels(miopen_gtest "${CMAKE_CURRENT_SOURCE_DIR}/test_categories.yaml" "${PROJECT_BINARY_DIR}/${DATABASE_INSTALL_DIR}" "${INSTALL_TEST_FILE}")
else()
message(STATUS "No test categorization (YAML missing)")
endif()

# Install CTestTestfile.cmake to bin/MIOpen/ subdirectory for TheRock distribution
if( NOT ENABLE_ASAN_PACKAGING )
install(
FILES "${INSTALL_TEST_FILE}"
DESTINATION "${CMAKE_INSTALL_BINDIR}/${PROJECT_NAME}"
COMPONENT tests
RENAME "CTestTestfile.cmake"
)
endif()

Loading
Loading