Skip to content

[rocPRIM] Add gfx1151 target arch details#3418

Closed
umfranzw wants to merge 1 commit into
developfrom
users/umfranzw/add_gfx1151_arch_details
Closed

[rocPRIM] Add gfx1151 target arch details#3418
umfranzw wants to merge 1 commit into
developfrom
users/umfranzw/add_gfx1151_arch_details

Conversation

@umfranzw
Copy link
Copy Markdown
Contributor

Motivation

Previously we added the gfx1151 build target to rocPRIM's CMakeLists.txt, but hadn't yet added the target_arch enum definition, wavefront size details, etc. This change adds in those remaining details.

Technical Details

Adds gfx1151 to the necessary locations in config.hpp and config_types.hpp.
We don't yet have any tuning configs for gfx1151, but when we do, this will be
needed in order to pick them up.

Test Plan

Build rocPRIM with cmake option -DAMDGPU_TARGETS=gfx1151. Then build tests and benchmarks. Ensure everything builds correctly.

Test Result

The build succeeds.

Submission Checklist

Previously we added the gfx1151 build target to rocPRIM's CMakeLists.txt,
but hadn't yet added the target_arch enum definition, wavefront size details, etc.
This change adds in those remaining details.
@umfranzw umfranzw requested a review from a team as a code owner December 16, 2025 17:45
@umfranzw umfranzw changed the title Add gfx1151 target arch details [rocPRIM] Add gfx1151 target arch details Dec 16, 2025
@stanleytsang-amd
Copy link
Copy Markdown
Contributor

I just noticed @NB4444 's #2955 added gfx1151 support this morning 85f49bf. Didn't see that before. I think we can close this PR in favour of Nick's?

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...im/rocprim/include/rocprim/device/config_types.hpp 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #3418       +/-   ##
============================================
+ Coverage    54.67%   75.38%   +20.71%     
============================================
  Files           14       95       +81     
  Lines         3980     9724     +5744     
  Branches       595      547       -48     
============================================
+ Hits          2176     7330     +5154     
- Misses        1544     1897      +353     
- Partials       260      497      +237     
Flag Coverage Δ
hipFFT ?
rocPRIM 75.38% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rojects/rocprim/rocprim/include/rocprim/config.hpp 100.00% <ø> (ø)
...im/rocprim/include/rocprim/device/config_types.hpp 50.99% <0.00%> (ø)

... and 107 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@umfranzw
Copy link
Copy Markdown
Contributor Author

I just noticed @NB4444 's #2955 added gfx1151 support this morning 85f49bf. Didn't see that before. I think we can close this PR in favour of Nick's?

Nice catch, thanks. Sure, I'll close this one in favour of Nick's.

@umfranzw umfranzw closed this Dec 17, 2025
ammallya pushed a commit that referenced this pull request Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants