[rocPRIM] Add gfx1151 target arch details#3418
Closed
umfranzw wants to merge 1 commit into
Closed
Conversation
Previously we added the gfx1151 build target to rocPRIM's CMakeLists.txt, but hadn't yet added the target_arch enum definition, wavefront size details, etc. This change adds in those remaining details.
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3418 +/- ##
============================================
+ Coverage 54.67% 75.38% +20.71%
============================================
Files 14 95 +81
Lines 3980 9724 +5744
Branches 595 547 -48
============================================
+ Hits 2176 7330 +5154
- Misses 1544 1897 +353
- Partials 260 497 +237
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Previously we added the gfx1151 build target to rocPRIM's CMakeLists.txt, but hadn't yet added the target_arch enum definition, wavefront size details, etc. This change adds in those remaining details.
Technical Details
Adds gfx1151 to the necessary locations in config.hpp and config_types.hpp.
We don't yet have any tuning configs for gfx1151, but when we do, this will be
needed in order to pick them up.
Test Plan
Build rocPRIM with cmake option -DAMDGPU_TARGETS=gfx1151. Then build tests and benchmarks. Ensure everything builds correctly.
Test Result
The build succeeds.
Submission Checklist