[Origami] fp4 fix#3407
Closed
bnemanich wants to merge 2 commits into
Closed
Conversation
Member
|
Merged in #3452 |
ammallya
pushed a commit
that referenced
this pull request
Feb 3, 2026
[ROCm/composable_kernel commit: 45c4ea5]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The use of
data_type_to_bytesin Origami is causing incorrect calculations in sub-byte datatypes (such as FP4). This has caused a regression in hipBLASLt performance.Technical Details
data_type_to_bytescurrently returns an integer, and sub-byte datatypes sizes are rounded up to 1. This PR changesdata_type_to_bytesto return adouble, so FP4 will be represented as0.5bytes.Test Plan
A new test was added to check for a few FP4 calculations of
rank_configs. #3301 should also be updated to added some more fp4 unit tests.Test Result
All Origami tests passing locally.
Submission Checklist