[TheRock CI] Adding windows build for TheRock CI#315
Merged
Conversation
geomin12
changed the title
ScottTodd
reviewed
Jun 23, 2025
geomin12
commented
Jun 30, 2025
ScottTodd
reviewed
Jun 30, 2025
ScottTodd
approved these changes
Jun 30, 2025
amd-chrissosa
added a commit
that referenced
this pull request
Jul 1, 2025
This reverts commit 5c13c00.
amd-chrissosa
added a commit
that referenced
this pull request
Jul 1, 2025
Reverts #315 This PR breaks post submit: https://github.com/ROCm/rocm-libraries/actions/runs/15988190629/job/45096452132 - looks like the GH Windows Build runners can't sync with this change.
ScottTodd
reviewed
Jul 1, 2025
Comment on lines
+44
to
+53
| - name: "Checking out repository for rocm-libraries" | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| repository: ${{ github.repository }} | ||
| ref: refs/pull/${{ github.event.pull_request.number }}/merge | ||
| sparse-checkout: | | ||
| .github | ||
| ${{ inputs.subtree_checkout }} | ||
| fetch-depth: 0 # Needed for subtree splitting | ||
| token: ${{ steps.generate-token.outputs.token }} |
Member
There was a problem hiding this comment.
This PR broke postsubmit and was reverted: #467. See logs at https://github.com/ROCm/rocm-libraries/actions/runs/15988190629/job/45096452132#step:3:55
Fetching the repository
"C:\Program Files\Git\cmd\git.exe" -c protocol.version=2 fetch --prune --no-recurse-submodules --filter=blob:none origin +refs/heads/*:refs/remotes/origin/* +refs/tags/*:refs/tags/* +refs/pull//merge:refs/remotes/pull//merge
Error: fatal: invalid refspec '+refs/pull//merge:refs/remotes/pull//merge'
The process 'C:\Program Files\Git\cmd\git.exe' failed with exit code 128
The checkout code here should instead match what is on Linux:
rocm-libraries/.github/workflows/therock-ci-linux.yml
Lines 42 to 48 in a672446
Without the ref: refs/pull/${{ github.event.pull_request.number }}/merge
Contributor
|
As Scott noted I had to revert this one. May be good to also ensure we get the build part in presubmit as part of the PR |
geomin12
added a commit
that referenced
this pull request
Jul 7, 2025
In order to get a signal that windows builds work for monorepo, we are adding build only for gfx1100 (tests are failing) [Build working here](https://github.com/ROCm/rocm-libraries/actions/runs/15980485092/job/45073555378?pr=315) Closes [TheRock 665](ROCm/TheRock#665)
geomin12
pushed a commit
that referenced
this pull request
Jul 7, 2025
Reverts #315 This PR breaks post submit: https://github.com/ROCm/rocm-libraries/actions/runs/15988190629/job/45096452132 - looks like the GH Windows Build runners can't sync with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to get a signal that windows builds work for monorepo, we are adding build only for gfx1100 (tests are failing)
Build working here
Closes TheRock 665