[rocBLAS] Users/torrezuk/swdev 568158 syrk ex tolerance fix (#2851)#2873
Merged
idass1990 merged 1 commit intoNov 27, 2025
Merged
Conversation
* fix syrk_ex tolerance due to reference conversions and add double precision reference function * add gfx11 tolerance template using f32 for f64 compute (cherry picked from commit d471513)
amcamd
approved these changes
Nov 24, 2025
Contributor
Contributor
|
also please note that the CI checked out theRock/ adjustment probably need to be done at least here: and same for windows |
Contributor
|
To fix the CI on release branch to check out the correct TheRock, please merge when the build is green: #2962 |
Contributor
Author
|
@HereThereBeDragons thanks if you fix the CI to build against the correct branch that will be good. As for test coverage all these test don't cover my changes at all. I tested locally but on different stack and on a gfx1100. Branch is protected so I can't merge anyway. |
Contributor
|
@TorreZuk checking with rocm-libraries gardener channel if this can be merged with override |
HereThereBeDragons
pushed a commit
to ROCm/TheRock
that referenced
this pull request
Nov 28, 2025
bump rocm-libraries from release/therock-7.10 20251127 Includes cherry picks : ROCm/rocm-libraries#2873 ROCm/rocm-libraries#2936 Co-authored-by: aravind-ravi1206 <therockbot@amd.com>
tfalders
pushed a commit
to tfalders/rocm-libraries
that referenced
this pull request
Jan 21, 2026
* Remove C++20 code C++20 features should not be used in CK. Remove all C++20 code. * fix c++17 build * format * fix merge issue --------- Co-authored-by: Thomas Ning <Thomas.Ning@amd.com> Co-authored-by: Max Podkorytov <4273004+tenpercent@users.noreply.github.com>
ammallya
pushed a commit
that referenced
this pull request
Feb 3, 2026
* Remove C++20 code C++20 features should not be used in CK. Remove all C++20 code. * fix c++17 build * format * fix merge issue --------- Co-authored-by: Thomas Ning <Thomas.Ning@amd.com> Co-authored-by: Max Podkorytov <4273004+tenpercent@users.noreply.github.com> [ROCm/composable_kernel commit: a5d1e25]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit d471513)