[rocWMMA] Set RPATH flag when Ninja is used on Unix#2822
Merged
Conversation
evedovelli
approved these changes
Nov 21, 2025
Avoids the need to explicitly set this flag when building with Ninja.
bsyrowik
force-pushed
the
users/bsyrowik/add_ninja_flag
branch
from
aa26e4c to
9dd207c
Compare
BradPepersAMD
pushed a commit
that referenced
this pull request
Nov 21, 2025
* merge felix/sorting * opt moe sorting (#2822) * opt moe storing for 2k --------- Co-authored-by: lalala-sh <Jiaxing.Wen@amd.com> Co-authored-by: coderfeli <coderfeli@163.com>
bsyrowik
added a commit
that referenced
this pull request
Nov 21, 2025
Cherry-pick of ff64c21 Also add change from #2822 Use CMAKE to set RPATH to avoid differences between Make and Ninja <!-- Explain the changes along with any relevant GitHub links. --> Compile with both Make and Ninja, check RPATH. RPATH now set properly in both cases. - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
assistant-librarian Bot
pushed a commit
to ROCm/rocWMMA
that referenced
this pull request
Nov 24, 2025
[rocWMMA] Set RPATH flag when Ninja is used on Unix
bsyrowik
added a commit
that referenced
this pull request
Nov 26, 2025
ammallya
pushed a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Avoids the need to explicitly set this flag when building with Ninja.
Technical Details
Test Plan
Test Result
Submission Checklist