Skip to content

CMS implementation for 192x256x64TN#2792

Merged
jfactory07 merged 28 commits into
hipblaslt_common_cms_devfrom
users/jzhou/cms-192x256x64TN
Dec 1, 2025
Merged

CMS implementation for 192x256x64TN#2792
jfactory07 merged 28 commits into
hipblaslt_common_cms_devfrom
users/jzhou/cms-192x256x64TN

Conversation

@jfactory07
Copy link
Copy Markdown
Contributor

@jfactory07 jfactory07 commented Nov 20, 2025

Motivation

resubmit #2623 after fix random test fail

I have run the test 8 times without failures

image

talumbau and others added 10 commits November 11, 2025 08:08
## Motivation

We are about to land a significant number of custom schedules for
various tile sizes and transpose orientations. By using the convention
"a schedule is described in a function" we can reasonably scale the code
out, instead of a chain of if/elif blocks that spans hundreds or
thousands of lines. Initially we keep the existing schedules in
functions inside CustomSchedule.py, but we can refactor as needed.

## Technical Details


## Test Plan

TENSILELITE_CLIENT_ARGS="--build-type Debug --gpu-targets gfx950
--clean" tox -e py39 -- Tensile/Tests -k custom_mainloop_scheduling.yaml
## Test Result

<!-- Briefly summarize test outcomes. -->
@jfactory07 jfactory07 marked this pull request as ready for review November 21, 2025 02:18
@jfactory07 jfactory07 requested a review from a team as a code owner November 21, 2025 02:18
@jfactory07 jfactory07 changed the title Users/jzhou/cms 192x256x64 tn CMS implementation for 192x256x64TN Nov 21, 2025
Comment thread projects/hipblaslt/tensilelite/Tensile/Components/CustomSchedule.py Outdated
Copy link
Copy Markdown
Contributor

@sebvince sebvince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done a full review, just answering TJ question. However, I did a quick test of the provided CSM, and the test fails on my machine when I use 192x256 instead of 256x192.
Also, I don’t see the updated solution in the YAML file. Is that intentional?

Comment thread projects/hipblaslt/tensilelite/Tensile/Components/CustomSchedule.py Outdated
@jfactory07
Copy link
Copy Markdown
Contributor Author

I haven't done a full review, just answering TJ question. However, I did a quick test of the provided CSM, and the test fails on my machine when I use 192x256 instead of 256x192. Also, I don’t see the updated solution in the YAML file. Is that intentional?

a mistake. I have added it.

@jfactory07 jfactory07 added the gfx950 run CI on gfx950 label Nov 26, 2025
Comment thread projects/hipblaslt/tensilelite/Tensile/Components/CustomSchedule.py
Comment thread projects/hipblaslt/tensilelite/Tensile/Components/CustomSchedule.py Outdated
Copy link
Copy Markdown
Contributor

@sebvince sebvince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@jfactory07 jfactory07 merged commit e5a8f48 into hipblaslt_common_cms_dev Dec 1, 2025
30 checks passed
@jfactory07 jfactory07 deleted the users/jzhou/cms-192x256x64TN branch December 1, 2025 09:09
b-shi pushed a commit that referenced this pull request Dec 12, 2025
ammallya pushed a commit that referenced this pull request Feb 3, 2026
[ROCm/composable_kernel commit: 9e71e9f]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants