[rocWMMA] Add --gc-sections flag to clean up number of ELF sections#2771
Merged
Conversation
darren-amd
changed the title
bsyrowik
approved these changes
Nov 19, 2025
Contributor
bsyrowik
left a comment
bsyrowik
left a comment
There was a problem hiding this comment.
Thanks Darren! Could you please update the PR description with the numbers you are seeing for the reduction in ELF sections for the binaries in question?
Contributor
|
It may be a while before the rocwmma test timeouts are sorted out. In the meantime, feel free to have a gardener help with submitting this. |
assistant-librarian Bot
pushed a commit
to ROCm/rocWMMA
that referenced
this pull request
Nov 24, 2025
[rocWMMA] Add --gc-sections flag to clean up number of ELF sections (#2771)
bsyrowik
pushed a commit
that referenced
this pull request
Nov 26, 2025
1 task
ammallya
pushed a commit
that referenced
this pull request
Feb 3, 2026
[ROCm/composable_kernel commit: 8d43155]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #2769. Currently when TheRock is building python packages, it is using the
patchelf --print-rpathutility to normalize rpaths. Because the generated test binaries have over 64k ELF sections, this is failing, so this fix is aimed at cleaning up the binaries.The two failing binaries were:
gemm_PGR1_LB2_MP0_MB_CP_WG-validate: ~66k -> ~44k sectionsgemm_PGR1_LB2_MP0_MB_CP_WV-validate~66k -> ~43k sectionsTechnical Details
Add the
--gc-sectionsflag when building the rocWMMA testsTest Plan
Verify that rocWMMA builds correctly
Test Result
rocWMMA builds with the resultant test binaries having fewer ELF sections
Submission Checklist