[MIOpen] Fix runtime kernel compilation issues#2510
Merged
DarylHawkinsAMD merged 8 commits intodevelopfrom Dec 16, 2025
Merged
Conversation
…ariable from our HIP RTC interface. Clang already has the ability to both find ROCm on the machine and to take the value of ROCM_PATH from the environment if it's present.
DarylHawkinsAMD
changed the title
DarylHawkinsAMD
changed the title
added 4 commits
December 11, 2025 11:40
…ied to it so we need to switch back to adding it via a header path
assistant-librarian bot
pushed a commit
to ROCm/MIOpen
that referenced
this pull request
Dec 16, 2025
[MIOpen] Fix runtime kernel compilation issues ## Motivation When generating the kernel compilation args for HIP RTC we were: * Adding `--rocm-path=.`. This is incorrect as the `.` resolves to the current directory, which is a temporary directory that contains the kernel code during runtime kernel compilation. This path does not contain a ROCm installation and adding this flag also disables the compiler's ability to automatically detect the ROCm installation location. In MIOpen CI's case this wasn't causing a failure because of the next point * Trying to add the ROCm headers location to the compilation flags by: * Looking at the value of the ROCM_PATH environment variable and using it * Falling back to using the hard-coded value `/opt/rocm` and appending `/includes` In TheRock, ROCm will not be installed at `/opt/rocm` and its location generally should not be relied upon as it makes our library less portable. It was causing test failures after a recent compiler promotion in TheRock as we were relying on incorrect behaviour and only succeeding coincidentially in our own MIOpen CI environment due to ROCm being installed at `/opt/rocm`. ## Technical Details * Remove hard-coded ROCm paths and but maintain the ability to use the ROCM_PATH environment variable ## Test Plan * Full CI run ## Test Result * Full CI run pending ## Submission Checklist - [X] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
ammallya
pushed a commit
that referenced
this pull request
Feb 3, 2026
[ROCm/composable_kernel commit: 0953932]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When generating the kernel compilation args for HIP RTC we were:
--rocm-path=.. This is incorrect as the.resolves to the current directory, which is a temporary directory that contains the kernel code during runtime kernel compilation. This path does not contain a ROCm installation and adding this flag also disables the compiler's ability to automatically detect the ROCm installation location. In MIOpen CI's case this wasn't causing a failure because of the next point/opt/rocmand appending/includesIn TheRock, ROCm will not be installed at
/opt/rocmand its location generally should not be relied upon as it makes our library less portable. It was causing test failures after a recent compiler promotion in TheRock as we were relying on incorrect behaviour and only succeeding coincidentially in our own MIOpen CI environment due to ROCm being installed at/opt/rocm.Technical Details
Test Plan
Test Result
Submission Checklist