[rocFFT] Add ability to configure kernel per architecture

[eng-flavio-teixeira]

Motivation

Add the ability to configure kernel parameters (workgroup size, threads-per-transform, length factorization, etc..) per architecture and precision.

Technical Details

Main changes are contained within kernel-generator.py and function_pool.h, where the concept of architecture has been added.
For regular entries in kernel-generator.py that do not specify the architecture, the concept of gfx_generic is introduced to deal with those. The generic entries should behave similar to configuration entries before the current changes. The gfx_generic concept also supports different lds size configurations similar to what we currently have implemented.

Test Plan

Current tests should pass without issues and no additional tests are required for now. Performance should also not be affected by the current changes. Once this PR is merged, new kernels will be added with per precision/architecture optimizations.

Test Result

All tests should pass without any issues.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 56.47059% with 37 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...rojects/rocfft/library/src/include/function_pool.h	41.38%	15 Missing and 2 partials ⚠️
...ects/rocfft/library/src/include/function_map_key.h	51.61%	15 Missing ⚠️
projects/rocfft/shared/device_properties.h	66.67%	2 Missing and 3 partials ⚠️

❗ There is a different number of reports uploaded between BASE (edc55b2) and HEAD (5210b5c). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (edc55b2)	HEAD (5210b5c)
hipSPARSE	1	0

Additional details and impacted files

@@             Coverage Diff              @@
##           develop    #2450       +/-   ##
============================================
- Coverage    85.85%   52.93%   -32.92%     
============================================
  Files          303      120      -183     
  Lines        21742    29438     +7696     
  Branches         0     3799     +3799     
============================================
- Hits         18665    15582     -3083     
- Misses        3077    12841     +9764     
- Partials         0     1015     +1015     

Flag	Coverage Δ
hipSPARSE	?
rocFFT	52.93% <56.47%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...rocfft/library/src/device/generator/stockham_gen.h	84.62% <100.00%> (ø)
...rojects/rocfft/library/src/rtc_stockham_kernel.cpp	81.61% <100.00%> (ø)
projects/rocfft/shared/device_properties.h	47.37% <66.67%> (ø)
...ects/rocfft/library/src/include/function_map_key.h	38.14% <51.61%> (ø)
...rojects/rocfft/library/src/include/function_pool.h	39.81% <41.38%> (ø)

... and 418 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[evetsso]

Is there any reason you didn't just use empty string for the generic arch name?

[eng-flavio-teixeira]

Is there any reason you didn't just use empty string for the generic arch name?

I thought the generic arch name would make more sense than an empty string for describing the purpose here, but an empty string should also work.

[eng-flavio-teixeira]

Is there any reason you didn't just use empty string for the generic arch name?

An empty string would be annoying to handle in the getline() loop in stockham_gen.cpp.
The gfx_generic could be removed from the supported_arch enum in config_arch.py, but it is much easier if we have something other than an empty string to parse the line in stockham_gen.

[malcolmroberts]

I mentioned device instead of arch, but we can probably just add the relevant data like CU count, or whatever else we want.

[eng-flavio-teixeira]

I mentioned device instead of arch, but we can probably just add the relevant data like CU count, or whatever else we want.

Are you thinking of replacing arch with more detailed data like CU count, LDS size, L1/L2/L3 cache etc..., or this would be in addition to arch? And do we want to tune with that level of detail?